From owner-freebsd-scsi@FreeBSD.ORG Tue Jun 3 18:51:29 2014 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3CDBEC28 for ; Tue, 3 Jun 2014 18:51:29 +0000 (UTC) Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 02B702A8D for ; Tue, 3 Jun 2014 18:51:28 +0000 (UTC) Received: by mail-ig0-f170.google.com with SMTP id h3so754088igd.3 for ; Tue, 03 Jun 2014 11:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=XaY4vfcTAul+m/Dr5I2LaeoIVtiPp3xnD5QjKrkYh1Q=; b=mj+u5spRMTOS8Y52IHDfbstwap7+ijkuLIzGsxiFAzN3y/jGrj/Pfc499wLnsbaalz g4r0ypsEBGM96eYnclwnKPFg7rbFn2xkz8A/7LYs29Gb3YekvQj+Q/SuYQOBHGL0aaGs KBD1SGe291xsA+C6kE/foCvihvrsrzcf85P1rZr6/NhbC+o6pSX4GGg+2Gx6rgInJV8h RioxqY1y5C17VOFvMg4yz8eru/bQxmFhyPRfr9jIcd8UB/Im/QanFItA7drXe51r83C2 zslbDSh4IgLU+bsmbAyY/UVJ+5X9RPoAHoz7FYNh3W9JK0yAUxxNXhspjbQA9257mJ1O Ks+w== X-Gm-Message-State: ALoCoQkS3eBZ86eclNEHJw/KsSULUi8D+00uH9fg4UVM4MvTFDgzWnQH2ftoFWDDJNE3PBJErOB4 X-Received: by 10.42.147.5 with SMTP id l5mr6032869icv.89.1401821024431; Tue, 03 Jun 2014 11:43:44 -0700 (PDT) Received: from [10.0.0.119] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id y7sm38769824igl.13.2014.06.03.11.43.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Jun 2014 11:43:43 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: Review needed From: Warner Losh In-Reply-To: <20140603182252.GF31367@funkthat.com> Date: Tue, 3 Jun 2014 12:43:43 -0600 Message-Id: <8FE17C18-08AB-4324-A059-D277792CC630@bsdimp.com> References: <20140603182252.GF31367@funkthat.com> To: John-Mark Gurney X-Mailer: Apple Mail (2.1878.2) Cc: freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 18:51:29 -0000 --Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jun 3, 2014, at 12:22 PM, John-Mark Gurney wrote: > Warner Losh wrote this message on Mon, Jun 02, 2014 at 10:46 -0600: >> The code that combines adjacent ranges for BIO_DELETEs to optimize >> trims to the device assumes the list is sorted. Don't apply the >> optimization of not sorting the queue when we have SSDs to the >> delete_queue, since it causes more discard traffic to the drive. = While >=20 > I'm puzzled by this statement, if I remove the double negative, I get: > Do apply the optimization of sorting the queue when we have SSDs to = the > delete_queue, since it (what the new optimizations?) causes more = discard > traffic to the drive. >=20 > Do you mean previously? Yes, it should reduce traffic because sorting allows ranges to be = collapsed. it =3D=3D the lack of sorting I=92ll tweak the commit message to be less opaque. >> one could argue that the higher levels should coalesce the trims, >> that's not done today, so some optimization at this level is needed. >>=20 >> Diffs and a (hopefully) cool review tool: = https://phabric.freebsd.org/D142 >=20 > Please include a raw diff... A Phabric is only for FreeBSD = committers, > it takes the rest of the community out of the ability to review. I thought people w/o an account could at least see the diff. Looks like = that=92s not the case (and somewhat lame). You can get the same thing from my hg patch queue: http://people.freebsd.org/~imp/patch-queue/bio_delete Warner --Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTjhdfAAoJEGwc0Sh9sBEA94wQAKiVXPit6Sy85kaa7rlRqDyY 0W154CrfXXAAKhhROabcNTopEYwYYaIPlHlrYc3aqGa33rmfcu5uD8befWMA5FZg 9dtgWsKp5W3nAuGiCA3b+JskCkU2Ki1DU0PGY731jPMmfQ/oVeoMVB+Xbgd+cymX DfVSsjx167+9z+COR+efSag2kkR8c8tmb9AI8d/qhcGZGv1juD7Ci4gR1A7jxyb6 PQNlOBcyUNv5YKgSLFW5svpuwuqY6Yei4M7X5VzmDJH3xJ3/dKxYkX0jnk5+UPNX Or4vIYk3RnUudfqAkB/FDD/FeBj2qTNjvmn3L/hbVf4iADmDkGhHxJcrI9GEoMn+ +UEimmvs+GJ0JgZj7YsFdVAbNTJL4aXPp94pitz07dDkxIMrcoUWHAsLqPjcqg1V ucuO43tLdMPwXFAwW/g26dmPnjiVRNY2bdwcsXu/3aOD2lbw6vd22gdzY8OOvpA/ x3e8pYYcY8BUdYId1uH05jPdUqcKgX5YhElZZ5DZHYg9cZg1ywjHCyJVgL9uYeRg TtwuFjdQ/rJWy/Shw7QseP2v4849OTLDpMeVKc5GngoSm7BWpcwA5onBMv20YFDL kxc3sHLRmEtNJ5uA9tFEk9JkyDwHO4smhzKTZO5cfO85PNfb+C2t926zkZ75I7LH 6ws4/r4VBf8SfQiu8dXO =gTeQ -----END PGP SIGNATURE----- --Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11--