From owner-freebsd-current@FreeBSD.ORG  Thu Nov 22 09:39:21 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 445D3D7E
 for <freebsd-current@freebsd.org>; Thu, 22 Nov 2012 09:39:21 +0000 (UTC)
 (envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 263D78FC12
 for <freebsd-current@freebsd.org>; Thu, 22 Nov 2012 09:39:21 +0000 (UTC)
Received: from xyf.my.dom (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAM9dKA4083986
 for <freebsd-current@freebsd.org>; Thu, 22 Nov 2012 09:39:20 GMT
 (envelope-from davidxu@freebsd.org)
Message-ID: <50ADF2D4.2010805@freebsd.org>
Date: Thu, 22 Nov 2012 17:39:32 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
 rv:14.0) Gecko/20120822 Thunderbird/14.0
MIME-Version: 1.0
To: freebsd-current@freebsd.org
Subject: Is this a typo in if_tap.c?
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Nov 2012 09:39:21 -0000

When I was trying to create a second tap device, kernel crashed.
Is this patch correct ?


Index: sys/net/if_tap.c
===================================================================
--- sys/net/if_tap.c	(revision 243397)
+++ sys/net/if_tap.c	(working copy)
@@ -186,7 +186,7 @@
  	/* Find any existing device, or allocate new unit number. */
  	i = clone_create(&tapclones, &tap_cdevsw, &unit, &dev, 0);
  	if (i) {
-		dev = make_dev(&tap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
+		dev = make_dev(&tap_cdevsw, unit, UID_ROOT, GID_WHEEL, 0600,
  		    "%s%d", tapname, unit);
  	}