From owner-cvs-src@FreeBSD.ORG Wed Oct 5 05:30:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D8B716A41F; Wed, 5 Oct 2005 05:30:25 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0CB9F43D45; Wed, 5 Oct 2005 05:30:25 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j955UOTU004305; Wed, 5 Oct 2005 05:30:24 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j955UOhQ004304; Wed, 5 Oct 2005 05:30:24 GMT (envelope-from truckman) Message-Id: <200510050530.j955UOhQ004304@repoman.freebsd.org> From: Don Lewis Date: Wed, 5 Oct 2005 05:30:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2005 05:30:25 -0000 truckman 2005-10-05 05:30:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_proc.c Log: MFC kern_proc.c - fix locking in sysctl_kern_proc() Original commit message: FreeBSD src repository Modified files: sys/kern kern_proc.c Log: Always wire the sysctl output buffer in sysctl_kern_proc() before calling sysctl_out_proc(). -- fix from jhb Move the code in fill_kinfo_thread() that gathers data from struct proc into the new function fill_kinfo_proc_only(). Change all callers of fill_kinfo_thread() to call both fill_kinfo_proc_only() and fill_kinfo() thread. When gathering data from a multi-threaded process, fill_kinfo_proc_only() only needs to be called once. Grab sched_lock before accessing the process thread list or calling fill_kinfo_thread(). PR: kern/84684 Approved by: re (scottl) Revision Changes Path 1.230.2.1 +114 -96 src/sys/kern/kern_proc.c