From owner-svn-src-all@freebsd.org  Mon Nov 16 02:08:42 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DB73A2FE4A;
 Mon, 16 Nov 2015 02:08:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 5198E1B33;
 Mon, 16 Nov 2015 02:08:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 502801152; Mon, 16 Nov 2015 02:08:42 +0000 (UTC)
Date: Mon, 16 Nov 2015 02:08:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: John-Mark Gurney <jmg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r290900 - head/sbin/restore
Message-ID: <20151116020842.GA5488@FreeBSD.org>
References: <201511160129.tAG1Tx0V080628@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201511160129.tAG1Tx0V080628@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2015 02:08:42 -0000

On Mon, Nov 16, 2015 at 01:29:59AM +0000, John-Mark Gurney wrote:
> New Revision: 290900
> URL: https://svnweb.freebsd.org/changeset/base/290900
> 
> Log:
>   If you backup a large file that is mostly holes, previously we'd issue
>   a seek for every block...  For large (Exabyte sized files) this would
>   issue lots of unneeded seeks, so combine them...
> 
> [...]
> @@ -938,14 +953,15 @@ getfile(void (*datafill)(char *, long), 
>  {
>  	int i;
>  	off_t size;
> +	long seekpos;

Briefly reading through tape.c, it looks like `long' is abused here (and in
other places).  IMHO we should try to fix these bugs, not add new misuses.

./danfe