From owner-freebsd-arch  Sat Aug 31  2:25:37 2002
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 715D037B400; Sat, 31 Aug 2002 02:25:34 -0700 (PDT)
Received: from jkh-gw.queasyweasel.com (adsl-64-173-3-158.dsl.sntc01.pacbell.net [64.173.3.158])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B032643E65; Sat, 31 Aug 2002 02:25:33 -0700 (PDT)
	(envelope-from jkh@queasyweasel.com)
Received: from adsl-64-173-15-99.dsl.sntc01.pacbell.net (jkh@mango.freebsd.com [64.173.15.99])
	by jkh-gw.queasyweasel.com (8.12.5/8.12.5) with ESMTP id g7V9PGWh025348;
	Sat, 31 Aug 2002 02:25:20 -0700 (PDT)
	(envelope-from jkh@queasyweasel.com)
Date: Sat, 31 Aug 2002 02:25:23 -0700
Subject: Re: pkg-routines ignore the recorded md5 checksums
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v543)
Cc: Mikhail Teterin <mi+mx@aldan.algebra.com>, arch@FreeBSD.org,
	jkh@FreeBSD.org
To: Kris Kennaway <kris@obsecurity.org>
From: Jordan K Hubbard <jkh@queasyweasel.com>
In-Reply-To: <20020831073845.GA74568@xor.obsecurity.org>
Message-Id: <936EE14E-BCC3-11D6-A85D-0003938C7B7E@queasyweasel.com>
Content-Transfer-Encoding: 7bit
X-Mailer: Apple Mail (2.543)
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

Works for me...  Go for it.

On Saturday, August 31, 2002, at 12:38 AM, Kris Kennaway wrote:

> On Sat, Aug 31, 2002 at 12:26:51AM -0700, Jordan K Hubbard wrote:
>> Hysterical Raisins.  We didn't even think of adding md5 checksums 
>> until
>> about a year or so after the pkg_install tools were done, and there 
>> was
>> concern at that point that adding another @foo directive would create 
>> a
>> set of "new packages" which didn't work with the older package tools.
>> So it was decided to simply make them a special type of comment, which
>> the previous package tools would simply ignore.  In hindsight, of
>> course...
>
> Perhaps we should change plist.c to make unrecognised commands
> non-fatal, so we can have more flexibility about extending the
> commandset in future.
>
> Kris
>
> Untested patch:
>
> Index: usr.sbin/pkg_install/lib/plist.c
> ===================================================================
> RCS file: /usr2/ncvs/src/usr.sbin/pkg_install/lib/plist.c,v
> retrieving revision 1.29.2.9
> diff -u -r1.29.2.9 plist.c
> --- usr.sbin/pkg_install/lib/plist.c	20 Aug 2002 06:35:08 
> -0000	1.29.2.9
> +++ usr.sbin/pkg_install/lib/plist.c	31 Aug 2002 07:37:51 -0000
> @@ -276,7 +276,7 @@
>  	cmd = plist_cmd(pline + 1, &cp);
>  	if (cmd == FAIL) {
>  	    cleanup(0);
> -	    errx(2, "%s: bad command '%s'", __func__, pline);
> +	    warnx("%s: unknown command '%s' (package tools out of date?)", 
> __func__, pline);
>  	}
>  	if (*cp == '\0') {
>  	    cp = NULL;
> <mime-attachment>
--
Jordan K. Hubbard
Engineering Manager, BSD technology group
Apple Computer


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message