From owner-freebsd-stable@FreeBSD.ORG Wed May 11 00:36:39 2005 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F73216A4CE; Wed, 11 May 2005 00:36:39 +0000 (GMT) Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D7B843D8A; Wed, 11 May 2005 00:36:38 +0000 (GMT) (envelope-from mi+mx@aldan.algebra.com) Received: from corbulon.video-collage.com (static-151-204-231-237.bos.east.verizon.net [151.204.231.237]) by aldan.algebra.com (8.13.1/8.13.1) with ESMTP id j4B0aX8H082489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 May 2005 20:36:37 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from mteterin.us.murex.com (195-11.customer.cloud9.net [168.100.195.11])j4B0aQqH077841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 May 2005 20:36:27 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from mteterin.us.murex.com (mteterin@localhost [127.0.0.1]) by mteterin.us.murex.com (8.13.3/8.13.3) with ESMTP id j4B0aLCx012643; Tue, 10 May 2005 20:36:21 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from localhost (localhost [[UNIX: localhost]]) by mteterin.us.murex.com (8.13.3/8.13.3/Submit) id j4B0aLOI012642; Tue, 10 May 2005 20:36:21 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) X-Authentication-Warning: mteterin.us.murex.com: mteterin set sender to mi+mx@aldan.algebra.com using -f From: Mikhail Teterin Organization: Virtual Estates, Inc. To: re@FreeBSD.org Date: Tue, 10 May 2005 20:36:20 -0400 User-Agent: KMail/1.7.2 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_FOVgCBOYinB9LG1" Message-Id: <200505102036.21194.mi+mx@aldan.algebra.com> X-Virus-Scanned: clamd / ClamAV version devel-20040615, clamav-milter version 0.73a on corbulon.video-collage.com X-Virus-Status: Clean X-Scanned-By: MIMEDefang 2.43 cc: stable@FreeBSD.org Subject: PTHREAD_INVARIANTS in 5.x X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2005 00:36:39 -0000 --Boundary-00=_FOVgCBOYinB9LG1 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello! As we were counting down to 5.3-RELEASE, I noticed, that all threading libraries still compile with PTHREAD_INVARIANTS. My suggestion to have this fixed was shutdown as not enough time was left for testing the 5.3. 6 months later the much anticipated 5.4 ships with these defines again and again FreeBSD is going to lose all thread-using benchmarks out there (such as MySQL's)... Can we have these things turned off NOW, so that, at least, 5.5 stands a chance? Thanks! -mi --Boundary-00=_FOVgCBOYinB9LG1 Content-Type: text/x-diff; charset="us-ascii"; name="inva.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="inva.patch" Index: lib/libc_r/Makefile =================================================================== RCS file: /meow/ncvs/src/lib/libc_r/Makefile,v retrieving revision 1.39.2.1 diff -U2 -r1.39.2.1 Makefile --- lib/libc_r/Makefile 13 Feb 2005 07:23:12 -0000 1.39.2.1 +++ lib/libc_r/Makefile 11 May 2005 00:22:12 -0000 @@ -19,5 +19,5 @@ # enable extra internal consistancy checks -CFLAGS+=-D_PTHREADS_INVARIANTS +#CFLAGS+=-D_PTHREADS_INVARIANTS PRECIOUSLIB= Index: lib/libpthread/Makefile =================================================================== RCS file: /meow/ncvs/src/lib/libpthread/Makefile,v retrieving revision 1.52.2.1 diff -U2 -r1.52.2.1 Makefile --- lib/libpthread/Makefile 13 Feb 2005 07:23:13 -0000 1.52.2.1 +++ lib/libpthread/Makefile 11 May 2005 00:22:23 -0000 @@ -35,5 +35,6 @@ # enable extra internal consistancy checks -CFLAGS+=-D_PTHREADS_INVARIANTS -Wall +#CFLAGS+=-D_PTHREADS_INVARIANTS -Wall +CFLAGS+=-Wall PRECIOUSLIB= Index: lib/libthr/Makefile =================================================================== RCS file: /meow/ncvs/src/lib/libthr/Makefile,v retrieving revision 1.7.2.1 diff -U2 -r1.7.2.1 Makefile --- lib/libthr/Makefile 13 Feb 2005 07:23:15 -0000 1.7.2.1 +++ lib/libthr/Makefile 11 May 2005 00:22:27 -0000 @@ -17,5 +17,5 @@ # enable extra internal consistancy checks -CFLAGS+=-D_PTHREADS_INVARIANTS +#CFLAGS+=-D_PTHREADS_INVARIANTS PRECIOUSLIB= --Boundary-00=_FOVgCBOYinB9LG1--