From owner-svn-src-head@FreeBSD.ORG Mon Jan 16 20:07:09 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D92D8106566C; Mon, 16 Jan 2012 20:07:09 +0000 (UTC) (envelope-from das@FreeBSD.org) Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101]) by mx1.freebsd.org (Postfix) with ESMTP id 9E1188FC1C; Mon, 16 Jan 2012 20:07:09 +0000 (UTC) Received: from zim.MIT.EDU (localhost [127.0.0.1]) by zim.MIT.EDU (8.14.5/8.14.2) with ESMTP id q0GK78jd087457; Mon, 16 Jan 2012 15:07:08 -0500 (EST) (envelope-from das@FreeBSD.org) Received: (from das@localhost) by zim.MIT.EDU (8.14.5/8.14.2/Submit) id q0GK78nh087456; Mon, 16 Jan 2012 15:07:08 -0500 (EST) (envelope-from das@FreeBSD.org) Date: Mon, 16 Jan 2012 15:07:08 -0500 From: David Schultz To: Bruce Evans Message-ID: <20120116200708.GC87187@zim.MIT.EDU> Mail-Followup-To: Bruce Evans , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201201160409.q0G49kHt014841@svn.freebsd.org> <20120116235547.P3191@besplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120116235547.P3191@besplex.bde.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r230193 - head/lib/libc/sparc64/fpu X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 20:07:09 -0000 On Tue, Jan 17, 2012, Bruce Evans wrote: > On Mon, 16 Jan 2012, David Schultz wrote: > > >Log: > > Computations on NaNs are supposed to return one of the input NaNs > > unchanged. > > Fix a few places in the sparc64 floating-point emulator where this wasn't > > being handled properly. > > > > Submitted by: bde > > Thanks. The only remaining large bug that I noticed near this is that > without -mhard-quad-float, signaling NaNs are not quieted and (IIRC) > FE_INVALID is not raised. > > BTW, NetBSD in 2005 uses Hauser soft-float for long doubles on sparc64, > and at least the MI parts of it are almost identical with the Hauser > soft-float in FreeBSD. But FreeBSD uses a completely different version > of soft-float for sparc64. It was apparently what NetBSD was using > in 2002 when it was imported into FreeBSD. Perhaps the Hauser version > is better (more correct or faster). However, the other version is > much simpler and looks much nicer -- it was originally from Berkeley > and has almost perfect KNF formatting (over 95% of lines are perfectly > formatted accoring to knfom; that is much better than 4.4BSD-Lite2 > sys/kern/*.c (88%) and FreeBSD-current sys/kern/*.c (89%, not counting > kern_intr.c which is about 0% after a single C++ comment in it confuses > indent(1)) and contrib/nvi/*/*.c (94%). Hauser soft-float has a Gnuish > style with 4-char indents amd is 26% KNF (probably mainly for the the > empty lines and some comments). softfloat is probably better. The style of contrib sources is what it is, and we have worse in the tree. That said, I don't have the cycles right now to fix what ain't broken. Moving all of the libc/quad/ floating-point routines to softfloat is more important, because that stuff *is* broken.