From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 9 16:02:42 2005 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2121116A4CE; Wed, 9 Mar 2005 16:02:42 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4E7543D5F; Wed, 9 Mar 2005 16:02:41 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j29G2fGt002287; Wed, 9 Mar 2005 08:02:41 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j29G2fp2002286; Wed, 9 Mar 2005 08:02:41 -0800 Date: Wed, 9 Mar 2005 08:02:41 -0800 From: Brooks Davis To: Gleb Smirnoff Message-ID: <20050309160241.GB30109@odin.ac.hmc.edu> References: <200503091520.j29FK5EF041922@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K8nIJk4ghYZn606h" Content-Disposition: inline In-Reply-To: <200503091520.j29FK5EF041922@freefall.freebsd.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-bugs@freebsd.org Subject: Re: kern/78227: Destroying a network interface leaks kernel memory X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2005 16:02:42 -0000 --K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > I like OpenBSD's solution. Please look at the attached patch; it > adds in_multi pointer into in_ifaddr, assigns it return value of > in_addmulti() and calls in_delmulti() when removing address. This looks fine to me. > P.S. I suspect we also have a memory leak when interface is joined a > multicast group and then destroyed. Actually, I believe it's a panic. :( I haven't had a chance to look at it much, but I put what I found in kern/77665. It's pretty easy to trigger if you have a pccard/cardbus nic. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --K8nIJk4ghYZn606h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCLx4gXY6L6fI4GtQRAuhFAJwIxR6eDe0bqvLTBD2fRv5Tqf48LgCgrL7U PnwjYhIFmkrTLthbiKiFOWo= =2ho7 -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--