Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Dec 2004 20:45:18 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Dag-Erling Sm?rgrav <des@des.no>
Cc:        geom@freebsd.org
Subject:   Re: GEOM_VOL panics when audio CD is present
Message-ID:  <20041230194518.GE784@darkness.comp.waw.pl>
In-Reply-To: <xzpsm5nvb53.fsf@dwp.des.no>
References:  <xzpfz1pksny.fsf@dwp.des.no> <xzpsm5nvb53.fsf@dwp.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help

--ytoMbUMiTKPMT3hY
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 30, 2004 at 08:28:24PM +0100, Dag-Erling Sm?rgrav wrote:
+> Any objections to the attached patch?  It's not the most efficient
+> solution, but it is the one least likely to give us surprises down the
+> road.

First of all I'll suggest to use glabel(8) instead of geom_vol_ffs, because
I want to remove geom_vol_ffs sometime in the future.

Maybe we can move SBLOCKSIZE check at function start?

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--ytoMbUMiTKPMT3hY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFB1FrOForvXbEpPzQRAqgbAKDJj+iiWMyxKFrHZlU07cgqC4vCFwCgsLe3
t80tYMB1mAYgO/s4rr9Y/b0=
=E1mv
-----END PGP SIGNATURE-----

--ytoMbUMiTKPMT3hY--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041230194518.GE784>