From nobody Thu Mar 20 02:53:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZJ9B52qTmz5r8j8; Thu, 20 Mar 2025 02:53:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZJ9B43Fq5z3c6G; Thu, 20 Mar 2025 02:53:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742439196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vjH7ALMGsU+4KiNSR1wJXGO8kR43BdBtfO9xAB4jP1c=; b=m7v9Nufn3RFes40klko2hd8fAtqhsUYmLt5MlRr9aH0pYTO3MvpQnqJAlisvN5bfU7yluj 7AtvLy83qOADuqeGIOURgjXr49d2la+cplzfo7kLUSO1seUXZVsqOKMmLtfdXbytkov4ai +lOl8IopyYUtiY2N00UYD5g0L7rtBLsQuO13zjcnOIHNqfTNoaM9Z/rD4c12K6VblmMuPP A7RZpKAUizteMAmb0wQBtNTXhr+x4XPsIgBqCZ4AQKZ7eBuUmQMfWQWry77Kozzsg7Lgv7 Vfef9D//jXDlcJUXwIJcllc+5gfgcEJxbni+6m/nLeGNMSMzXKNKl9EC5La0AQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742439196; a=rsa-sha256; cv=none; b=H+h8s8mwsPm0b8x8bIJ7ChcpM+fGAyRMn5cykgo184nfjzJnyg6ogtrwbSgZcN52sW6Pap WNuesPPuwyAVqLtXItjMeJ8noBUZjRcokkmoL2Iv3KxPrTagsJRGHvNdPwFuSjAmn8wG1V cdn5lz9x/rXBmju/i3TWeHHydrNgsVOMAOt6T2k8I3c2i/Tj84s7DsJAZda/mEusw16lEY 3wp11kBg0eWHLS+cGcK1Am3utXFwpXymuOkFmEh8RU+kQ1czl7UG5IuIE2nCzKRBArNqFR 6F180tnVc+eXoCJL8hwRYMRCixSf4E+i2/CX20xmOYyK2k8OVFNmVNXFXLo+HQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742439196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vjH7ALMGsU+4KiNSR1wJXGO8kR43BdBtfO9xAB4jP1c=; b=a5fVB8jbHkqo2EndBlJdDNwRWwaodXzaMV47hzVdxoa4jCcGx2odEFZLRKVre8HoOg2zoy ckWbNJQ/j4L87FR4LAXPu8Rc7N7v2RMD7fqx1wTZ6x3kWALfxNhs5irkPe8C8dQ9S7NndQ XdW59vJwKj1OqxFK63Rm8a4sngs+yzPVXVKm6Yxmjue1qwN0MNX7Pmh2p/87W54Ng5gVd5 BbamMC+D65mIO8kJ+0QE2af1fhQlB/oG/dmqlhx85A8RMoqZgwz46SevAbyu/eREFSOYC1 5y4jEjM/QKyO1nwrxy9a7kXnjuSPwpvfAAQIzJX+/m8Y4XYiom0eDs4NEC5CbQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZJ9B42kY3znCQ; Thu, 20 Mar 2025 02:53:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52K2rGHQ046502; Thu, 20 Mar 2025 02:53:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52K2rGIF046499; Thu, 20 Mar 2025 02:53:16 GMT (envelope-from git) Date: Thu, 20 Mar 2025 02:53:16 GMT Message-Id: <202503200253.52K2rGIF046499@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 48d6b52add36 - main - devfs: Return early from sysctl_devname() if no input is given List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 48d6b52add36cc09e7fb1fbec44ab66c0742f320 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=48d6b52add36cc09e7fb1fbec44ab66c0742f320 commit 48d6b52add36cc09e7fb1fbec44ab66c0742f320 Author: Mark Johnston AuthorDate: 2025-03-20 01:34:10 +0000 Commit: Mark Johnston CommitDate: 2025-03-20 01:34:10 +0000 devfs: Return early from sysctl_devname() if no input is given Otherwise we end up searching for a device using an uninitialized key, tripping up KMSAN. MFC after: 2 weeks --- sys/fs/devfs/devfs_devs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/fs/devfs/devfs_devs.c b/sys/fs/devfs/devfs_devs.c index db879efe803a..c6dcd4fc7646 100644 --- a/sys/fs/devfs/devfs_devs.c +++ b/sys/fs/devfs/devfs_devs.c @@ -86,6 +86,9 @@ sysctl_devname(SYSCTL_HANDLER_ARGS) struct cdev_priv *cdp; struct cdev *dev; + if (req->newptr == NULL) + return (EINVAL); + #ifdef COMPAT_FREEBSD11 if (req->newlen == sizeof(ud_compat)) { error = SYSCTL_IN(req, &ud_compat, sizeof(ud_compat));