From owner-freebsd-emulation  Sat Jun 12  2:57: 0 1999
Delivered-To: freebsd-emulation@freebsd.org
Received: from freebsd.dk (freebsd.dk [212.242.42.178])
	by hub.freebsd.org (Postfix) with ESMTP id 10D5414E9A
	for <emulation@FreeBSD.ORG>; Sat, 12 Jun 1999 02:56:56 -0700 (PDT)
	(envelope-from sos@freebsd.dk)
Received: (from sos@localhost)
	by freebsd.dk (8.9.1/8.9.1) id LAA13361;
	Sat, 12 Jun 1999 11:56:45 +0200 (CEST)
	(envelope-from sos)
From: Soren Schmidt <sos@freebsd.dk>
Message-Id: <199906120956.LAA13361@freebsd.dk>
Subject: Re: Bug in linux fcntl syscall?
In-Reply-To: <37621CAD.7E822846@scc.nl> from Marcel Moolenaar at "Jun 12, 1999 10:39: 9 am"
To: marcel@scc.nl (Marcel Moolenaar)
Date: Sat, 12 Jun 1999 11:56:45 +0200 (CEST)
Cc: emulation@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL43 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-freebsd-emulation@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

It seems Marcel Moolenaar wrote:
> Allan Saddi wrote:
> 
> > Today, after hours of truss'ing and strace'ing (on a RedHat 6 system), I
> > discovered the problem. In linux_file.c, the function linux_fcntl:
> 
> > Notice that fcntl_args.arg is always 0. This keeps the F_SETFD call from
> > ever setting the close-on-exec flag, which is precisely the problem. I
> > patched the LINUX_F_SETFD case to set fcntl_args.arg to args->arg, and
> > TclPro's prodebug now works fine.
> 
> > I would've filed a PR, but looking at the code, I see other cases that
> > set/assign fcntl_args.arg explicitly. So I'm wondering if this was a
> > design decision rather than a bug? (One of those feature vs. bugs things,
> > I guess. ;)
> 
> I wouldn't call it a bug. I wouldn't call it a feature either :-)
> Anyway, you should file the PR.

Its a bug allright, I'll look at it together with some other patches
for the emulator, anyone with special wishes currently, og outstanding
patches/fixes/upgrades? I'll merge the bits and commit... 

-Søren


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-emulation" in the body of the message