Date: Tue, 1 May 2012 20:04:53 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Michael Scheidell <scheidell@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/gwenhywfar pkg-plist ports/finance/aqbanking pkg-plist Message-ID: <20120502030453.GA33262@dormouse.experts-exchange.com> In-Reply-To: <201205011910.q41JA1g4058443@repoman.freebsd.org> References: <201205011910.q41JA1g4058443@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, May 01, 2012 at 07:10:01PM +0000, Michael Scheidell thus spake: >scheidell 2012-05-01 19:10:01 UTC > > FreeBSD ports repository > > Modified files: > devel/gwenhywfar pkg-plist > finance/aqbanking pkg-plist > Log: > - Revert %%DATADIR%% changes to pkg-plists. Application is not DATADIR safe > - No PORTREVISION bump since the defaults do not change package > > PR: ports/167461 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=167461 > Submitted by: Jason E. Hale <bsdkaffee@gmail.com> (maintainer) > > Revision Changes Path > 1.15 +26 -26 ports/devel/gwenhywfar/pkg-plist > 1.18 +154 -154 ports/finance/aqbanking/pkg-plist > >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/devel/gwenhywfar/pkg-plist.diff?&r1=1.14&r2=1.15&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/finance/aqbanking/pkg-plist.diff?&r1=1.17&r2=1.18&f=h > For the record, this did not break anything, and if anything, it is breaking some of the rules for installation, as it installs portdata outside of the portname, itself, in addition to the its' own portname directory inside the default DATADIR. All of this aside, the only place I have seen this reference to "DATADIR safe" is portlint. I have not seen it in bpm, or in the handbook. If portlint is correct, we need to update the other documentation to support it. To the point if it is unsafe -- every port that uses this, is then unsafe, and should be fixed. Beyond this, why not make it DATADIR safe, if there is an unsafe, for all applications by removing the configrability of it. Is there any reason that portdata should be installed elsewhere? In closing, if there is an unsafe, why are we supporting anything that is unsafe? Thanks. - -jgh - -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBAgAGBQJPoKRVAAoJECBZmmNBUNPcNcsH/1zZEZjqLhiXtIwFMs2SSJ5/ 9yYmfdwHsf5e1AlM4qNQoNEwdnIDDVvt3dYH8Twvu4ZMF2EaSBjf9dq0ZFiy7Og0 +9B0tipkfHGpG5ebq3Yj1vaZyfnGmaCtCd1nYXx1hYCz1uNFl2ffVoV1DSlwQY7Y oNqms2j/btxDTNM+zJzKgiyGgjLePr+5FkwpGVyfa2iRuZ6mNH9xjKSo0Wf6i32N WqOiVgudaq5V8pl3NAg8pjA2FBej8yvmzMM5QaxEvArowuRrn5Rfcnk0DP14pmdH P+OT1+SPlpoeuWPfGZrNLr7xuH80x2CIHtSqhWgziG8MRsWUnb3VyS5apXwoLks= =x9jJ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120502030453.GA33262>