From owner-freebsd-hackers@freebsd.org Tue Dec 6 09:52:34 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9950DC69070 for ; Tue, 6 Dec 2016 09:52:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 317E41560; Tue, 6 Dec 2016 09:52:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uB69qTLl075490 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 6 Dec 2016 11:52:29 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uB69qTLl075490 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id uB69qTIN075489; Tue, 6 Dec 2016 11:52:29 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 6 Dec 2016 11:52:29 +0200 From: Konstantin Belousov To: Eric van Gyzen Cc: FreeBSD Hackers Subject: Re: kinfo_proc::ki_tdname truncation Message-ID: <20161206095229.GL54029@kib.kiev.ua> References: <3379ac69-16e0-4071-8e69-4fb05b011ba7@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3379ac69-16e0-4071-8e69-4fb05b011ba7@FreeBSD.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 09:52:34 -0000 On Mon, Dec 05, 2016 at 08:29:29PM -0600, Eric van Gyzen wrote: > I just noticed that kinfo_proc::ki_tdname is three characters shorter than > thread::td_name. Would anyone object if I steal 4 bytes from ki_sparestrings to > add a field for these three extra characters (and fix all consumers > accordingly)? Yes, I care enough about those three characters to do this. > You also should update kinfo_proc32 and freebsd32_kinfo_proc_out() then.