From owner-cvs-src-old@FreeBSD.ORG  Fri Jul 29 23:55:37 2011
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3637D1065672
	for <cvs-src-old@freebsd.org>; Fri, 29 Jul 2011 23:55:37 +0000 (UTC)
	(envelope-from adrian@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C8B68FC0A
	for <cvs-src-old@freebsd.org>; Fri, 29 Jul 2011 23:55:37 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p6TNtamh023557
	for <cvs-src-old@freebsd.org>; Fri, 29 Jul 2011 23:55:36 GMT
	(envelope-from adrian@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p6TNtaEM023556
	for cvs-src-old@freebsd.org; Fri, 29 Jul 2011 23:55:36 GMT
	(envelope-from adrian@repoman.freebsd.org)
Message-Id: <201107292355.p6TNtaEM023556@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	adrian@repoman.freebsd.org using -f
From: Adrian Chadd <adrian@FreeBSD.org>
Date: Fri, 29 Jul 2011 23:55:17 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/dev/ath if_ath_sysctl.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2011 23:55:37 -0000

adrian      2011-07-29 23:55:17 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/ath          if_ath_sysctl.c 
  Log:
  SVN rev 224502 on 2011-07-29 23:55:17Z by adrian
  
  Reset the NIC if ANI is enabled or disabled.
  
  Although this may not be what the original sysctl was designed to do,
  it feels a bit more "expected".
  
  Before, if ANI is disabled, the initial ANI parameters are still written
  to the hardware, even if they're not enabled. "ANI enabled" would then
  adjust the noise immunity parameters dynamically. Disabling ANI would
  simply leave the existing noise immunity parameters where they are,
  and disable the dynamic part.
  
  The problem is that disabling ANI doesn't leave the hardware in
  a consistent, predictable state - so asking a user to disable ANI
  wouldn't actually reset the NIC to a consistent set of PHY signal
  detection parameters, resulting in an unpredictable/unreliable outcome.
  This makes it difficult to get reliable debugging information from
  the user.
  
  Approved by:    re (kib)
  
  Revision  Changes    Path
  1.7       +15 -1     src/sys/dev/ath/if_ath_sysctl.c