From owner-cvs-all Mon May 20 11:20:56 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by hub.freebsd.org (Postfix) with ESMTP id 8B72437B40A for ; Mon, 20 May 2002 11:20:42 -0700 (PDT) Received: (qmail 22084 invoked from network); 20 May 2002 18:20:40 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 20 May 2002 18:20:40 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4KIKfF91279; Mon, 20 May 2002 14:20:41 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200205201754.g4KHsnS42281@freefall.freebsd.org> Date: Mon, 20 May 2002 14:20:19 -0400 (EDT) From: John Baldwin To: John Baldwin Subject: RE: cvs commit: src/sys/vm uma_core.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 20-May-2002 John Baldwin wrote: > jhb 2002/05/20 10:54:48 PDT > > Modified files: > sys/vm uma_core.c > Log: > In uma_zalloc_arg(), if we are performing a M_WAITOK allocation, ensure > that td_intr_nesting_level is 0 (like malloc() does). Since malloc() calls > uma we can probably remove the check in malloc() for this now. Also, > perform an extra witness check in that case to make sure we don't hold > any locks when performing a M_WAITOK allocation. This revealed a lot of possible brokenness: > grep 'could' foo | sed -e 's/^.*could/could/' | sort | uniq -c | sort -nr 44 could sleep with "pcm0" locked from ../../../dev/sound/pcm/sound.c:134 25 could sleep with "UMA lock" locked from ../../../vm/uma_core.c:1157 10 could sleep with "process lock" locked from ../../../kern/kern_prot.c:511 10 could sleep with "pccbb0" locked from ../../../dev/pccbb/pccbb.c:891 9 could sleep with "pcm0:play:3" locked from ../../../dev/sound/pcm/channel.c:677 9 could sleep with "pcm0:mixer" locked from ../../../dev/sound/pcm/sound.c:134 6 could sleep with "pcm0:play:1" locked from ../../../dev/sound/pcm/channel.c:677 5 could sleep with "process lock" locked from ../../../kern/kern_prot.c:613 5 could sleep with "pcm0:play:2" locked from ../../../dev/sound/pcm/channel.c:677 5 could sleep with "pcm0:play:0" locked from ../../../dev/sound/pcm/channel.c:677 4 could sleep with "rl0" locked from ../../../pci/if_rl.c:855 4 could sleep with "rl0" locked from ../../../pci/if_rl.c:587 4 could sleep with "pcm0:fake" locked from ../../../dev/sound/pcm/channel.c:677 3 could sleep with "sf_bufs list lock" locked from ../../../kern/uipc_syscalls.c:1578 2 could sleep with "rman" locked from ../../../kern/subr_rman.c:194 2 could sleep with "rl0" locked from ../../../pci/if_rl.c:1413 1 could sleep with "rl0" locked from ../../../pci/if_rl.c:1524 -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message