From nobody Mon Mar 25 15:47:51 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V3HQ24LVRz5FBWF; Mon, 25 Mar 2024 15:47:54 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "Telekom Security ServerID OV Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V3HQ20674z4RhS; Mon, 25 Mar 2024 15:47:53 +0000 (UTC) (envelope-from garyj@gmx.de) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1711381672; x=1711986472; i=garyj@gmx.de; bh=7zPkyomIadl44wspyIiVBy9G8gZ2O93LgZF+uUh0t7E=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References: Reply-To; b=NY0J8n2QxeG4VPhIOkst3GfPLhcR9BtIWuG2JcgNZkanB08q/7Wg2jhwdm5zpbwj 3aCE4Wu0g8QvypCp0ELUYlHEXb/eufRBQrfUuH/xY2RYpgUrdTeRsX+KgCxQb5zMe m5ktxv5iuGS8CLnyitOBtwwPJu65qoi9u+Oom00gPvqHa5qz9vLTK/9g9+ZIJ6XEx I713lgteqR7SHNdlMdwb45P4yQbi64ZUlouWPtRwDIJHCKvgY+dXtxzPVhsPlnm3Y AQcwCbPplLIGHa60d4E1H4p7UlCUoGlcv2KpDSDiSbFPOQFT799f03JPfpIyYfHdC yfaZu608F1EvUQ/9ng== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from ernst.home ([91.59.224.160]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MPXd2-1sBNuc0otu-00MfWA; Mon, 25 Mar 2024 16:47:52 +0100 Date: Mon, 25 Mar 2024 15:47:51 +0000 From: Gary Jennejohn To: Mark Peek Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 65904399db91 - main - efibootmgr: allow -u as a valid option Message-ID: <20240325164751.21b85926@ernst.home> In-Reply-To: References: <202403241939.42OJdn3w018764@gitrepo.freebsd.org> <20240325100136.2a052359@ernst.home> Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:acMSPFzP0n+9WhGjka2ZNwzSNLzhe/OOEhd0Kb57VbhGoLcxil6 Gd7lAzhb9abvLKl/beMe7XpesZYg/yJGz+qFeLVZbU2cqzHigN8mmgAc7s5VAwyVDjWuBsc /lkoZxTKHvq0szFXYI8xGzbf0JAKQPZUrEN9CUVNeyVOO3JIC4p1htrVCjPs5JtC9hlAw54 DezLlsvsK3lMo2K8uFGzw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AUpnYm/cydg=;dz363fvrjrX9krPKBe3UH1JCfj8 qjjz42kicO17kpapJQOd2nW8pfS0tDglAnmyV7t4RbrlDGGicXRwU8LTV9kGJ3dpwW5v2i/64 Nn7uiuOFSplEf7GhMKwq6kMBeq0mHC55fZ/6DOYHAZB5Gdad+T6Jbt4eCY6Z/OjVcnpWWh+2l riOnjOVfkG+boM7WmpHCvrK/hN8y+d6IeNXwzuc4awsHh2L9dNZJDybT3Fzlj/rsRe+0LBhgt TbLoi95sIJHp+A/UlyrfU6ppKNNdosv8PhFyc+sJWML9D0E/mu3fI9nc3fDBcGn7nM+4jP0s+ iHUuLiXxmb7clr8rZqhEVhKjLgaFcyPdxHGS7ljJM4TfVa0NbuMsThCIm3IpPpIchEtWYs6Nh QCXxvGo5HjLNyHoO1CeyHFpxwvmXTe6rvE+7zXP3XGkRSnHg/grPvNJyRKpC7fQURw6eUcazE +Ha+R1Mbyw2W0gbAIaB49Ss5VmohqDNFQHWmSNt+Pgf7nc1YuaR5+mHWOkMgT0wqh1ePwD2Tn WShbp3bJ/Sbt2+mMu8O/QKltBDOV1+m9Vji9euWIErIELBGWdGRYM2LKDlZrIBtqZaE+VF3Yc ABU3DdcYFJM5/v++IJLnifU//yH6lN7tsFxlzcOfTePchwgzXHIcw6d9t/Wet+EjCjXgTFIhM AEgdL2INuKLgpCUmNWBwvBC4TUWNHtll0daonfaimsq2h4y+YAX3oasj1b03/HwWSXEqExlWW aTpIo6/jpxsNHEvKeKgCaS1mm5+mNwxCw/kMUuun5laTBTFZxEozXrNShd3VCYLQ2wydY35m3 FdbUWTzPMvZ5DSvDBI3yq8tqmirLnTFj9goKBxW3YdUVQ= X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE] X-Rspamd-Queue-Id: 4V3HQ20674z4RhS On Mon, 25 Mar 2024 07:37:54 -0700 Mark Peek wrote: > On Mon, Mar 25, 2024 at 2:01?AM Gary Jennejohn wrote: > > > On Sun, 24 Mar 2024 19:39:49 GMT > > Mark Peek wrote: > > > > > The branch main has been updated by mp: > > > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3D65904399db9167b0970e42e14642= e1d6bdbf6d3a > > > > > > commit 65904399db9167b0970e42e14642e1d6bdbf6d3a > > > Author: Mark Peek > > > AuthorDate: 2024-03-24 19:37:12 +0000 > > > Commit: Mark Peek > > > CommitDate: 2024-03-24 19:37:12 +0000 > > > > > > efibootmgr: allow -u as a valid option > > > > > > PR: 277907 > > > Reported by: vsasjason@gmail.com > > > MFC after: 1 week > > > --- > > > usr.sbin/efibootmgr/efibootmgr.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/usr.sbin/efibootmgr/efibootmgr.c > > b/usr.sbin/efibootmgr/efibootmgr.c > > > index 2bc79ee26f51..b919130d9c11 100644 > > > --- a/usr.sbin/efibootmgr/efibootmgr.c > > > +++ b/usr.sbin/efibootmgr/efibootmgr.c > > > @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[]) > > > int ch; > > > const char *arg; > > > > > > - while ((ch =3D getopt_long(argc, argv, > > "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:v", > > > - lopts, NULL)) !=3D -1) { > > > + while ((ch =3D getopt_long(argc, argv, > > > + "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:u:v", lopts, NULL)) !=3D -= 1) { > > > switch (ch) { > > > case 'A': > > > opts.set_inactive =3D true; > > > > > > > -u is not documented in the man page for efibootmgr, although it was > > already in the source. > > > > -- > > Gary Jennejohn > > > > Gary, > I'm not sure I understand your comment. The man page was updated for -u = in > this commit: > https://github.com/freebsd/freebsd-src/commit/9a7915299484a767fbffc7234b= 8dc45c29954cca > > And man shows this as: > efibootmgr -u unix-path > ... > -u --efidev unix-path > Displays the UEFI device path of unix-path. Ah yes. I looked at the man page under /usr/share/man/man8 which isn't up to date. I should have looked at /usr/src/usr.sbin/efibootmgr/efibootmgr.8 instead. Sorry for that. =2D- Gary Jennejohn