From owner-p4-projects@FreeBSD.ORG  Sat Aug 16 09:42:45 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0665037B404; Sat, 16 Aug 2003 09:42:45 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 97EEF37B401; Sat, 16 Aug 2003 09:42:44 -0700 (PDT)
Received: from milla.ask33.net (milla.ask33.net [217.197.166.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B3AF943F85; Sat, 16 Aug 2003 09:42:43 -0700 (PDT)
	(envelope-from nick@milla.ask33.net)
Received: by milla.ask33.net (Postfix, from userid 1001)
	id BFD003ABB3F; Sat, 16 Aug 2003 18:43:00 +0200 (CEST)
Date: Sat, 16 Aug 2003 18:43:00 +0200
From: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20030816164300.GS395@garage.freebsd.pl>
References: <200308062120.h76LKi3d003275@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="B2XwZuBUJ8PPSpsy"
Content-Disposition: inline
In-Reply-To: <200308062120.h76LKi3d003275@repoman.freebsd.org>
X-PGP-Key-URL: http://garage.freebsd.pl/jules.asc
X-OS: FreeBSD 4.8-RELEASE-p3 i386
X-URL: http://garage.freebsd.pl
User-Agent: Mutt/1.5.1i
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 35655 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Aug 2003 16:42:46 -0000


--B2XwZuBUJ8PPSpsy
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote:
+> -    mode ~=3D cmask;
+> +    mode =3D mode &~ cmask;

IMHO this is a style bug.

This should be: mode =3D mode & ~cmask;

On time, when I was tired, I've spend few minutes wondering why 'foo'
after this operation isn't equal to 'foo - bar':)

	foo =3D- bar;

--=20
Pawel Jakub Dawidek                       pawel@dawidek.net
UNIX Systems Programmer/Administrator     http://garage.freebsd.pl
Am I Evil? Yes, I Am!                     http://cerber.sourceforge.net

--B2XwZuBUJ8PPSpsy
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iQCVAwUBPz5fFD/PhmMH/Mf1AQFIugP8DHWvRG0vWdFoQL2v5McFuxTZmvFgcxqo
UmwdJvh/kQaAUXFyaXZmXSzjpRFkdl3EVSCVhhBmXS82kdjqM6nqotpdMes1K5E3
3BpZAchUhFb0xAzRsS7mSHlbftFIF7a+KKAZE8rpqmrD5kqREK9PxB4noQC8vc/9
/uEp4NZEVAw=
=Fse2
-----END PGP SIGNATURE-----

--B2XwZuBUJ8PPSpsy--