From owner-freebsd-net@FreeBSD.ORG Fri Mar 9 07:22:32 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4B82716A407; Fri, 9 Mar 2007 07:22:32 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from pobox.codelabs.ru (pobox.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id EBC5113C494; Fri, 9 Mar 2007 07:22:31 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from codelabs.ru (pobox.codelabs.ru [144.206.177.45]) by pobox.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1HPZQs-0008Ww-5m; Fri, 09 Mar 2007 10:22:30 +0300 Date: Fri, 9 Mar 2007 10:22:24 +0300 From: Eygene Ryabinkin To: Andrew Thompson Message-ID: <20070309072224.GR58523@codelabs.ru> References: <45E9F1E8.2000802@inse.ru> <20070304062203.GL80319@codelabs.ru> <45E9F1E8.2000802@inse.ru> <20070304160613.GN80319@codelabs.ru> <45EDA348.3030309@inse.ru> <20070307210254.GD54828@heff.fud.org.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20070307210254.GD54828@heff.fud.org.nz> Sender: rea-fbsd@codelabs.ru X-Spam-Status: No, score=-2.1 required=4.0 tests=ALL_TRUSTED,AWL,BAYES_50 Cc: rik@FreeBSD.org, Roman Kurakin , andre@FreeBSD.org, freebsd-net@freebsd.org, glebius@FreeBSD.org, bms@FreeBSD.org Subject: Re: kern/109815: wrong interface identifier at pfil_hooks for vlans + if_bridge X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2007 07:22:32 -0000 > > > > + /* Give a chance for ifp at first priority. This will help in case > > we > > + * the packet comes through the interface with VLAN's and the same > > + * MACs on several interfaces in a bridge. Also will save some > > circles > > + * in case dst interface is the physical input interface (eq ifp). > > + */ > > + if (ifp->if_type == IFT_GIF > ^^^^^^^^^^^^^^^^^^^^^^^ > is this check right? No, it should read if (ifp->if_type == IFT_GIF) continue; if (memcmp(IF_LLADDR(.....))) { ... } -- Eygene