Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Sep 2020 17:27:35 +0100
From:      Andrew Turner <andrew@fubar.geek.nz>
To:        Marcin Wojtas <mw@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r365054 - in head/sys: conf dev/sdhci
Message-ID:  <874D5323-F0DB-44E9-8779-7C18832A98B4@fubar.geek.nz>
In-Reply-To: <202009011617.081GHL8e031671@repo.freebsd.org>
References:  <202009011617.081GHL8e031671@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On 1 Sep 2020, at 17:17, Marcin Wojtas <mw@FreeBSD.org> wrote:
>=20
> Author: mw
> Date: Tue Sep  1 16:17:21 2020
> New Revision: 365054
> URL: https://svnweb.freebsd.org/changeset/base/365054
>=20
> Log:
>  Introduce the SDHCI driver for NXP QorIQ Layerscape SoCs
>=20
>  Implement support for an eSDHC controller found in NXP QorIQ =
Layerscape SoCs.
>=20
>  This driver has been tested with NXP LS1046A and LX2160A (Honeycomb =
board),
>  which is incompatible with the existing sdhci_fsl driver (aiming at =
older
>  chips from this family). As such, it is not intended as replacement =
for
>  the old driver, but rather serves as an improved alternative for SoCs =
that
>  support it.
>  It comes with support for both PIO and Single DMA modes and samples =
the
>  clock from the extres clk API.
>=20
>  Submitted by: Artur Rojek <ar@semihalf.com>
>  Reviewed by: manu, mmel, kibab
>  Obtained from: Semihalf
>  Sponsored by: Alstom Group
>  Differential Revision: https://reviews.freebsd.org/D26153
>=20
> Added:
>  head/sys/dev/sdhci/sdhci_fsl_fdt.c   (contents, props changed)
> Modified:
>  head/sys/conf/files
>=20
> Modified: head/sys/conf/files
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/conf/files	Tue Sep  1 16:13:09 2020	=
(r365053)
> +++ head/sys/conf/files	Tue Sep  1 16:17:21 2020	=
(r365054)
> @@ -3058,6 +3058,7 @@ dev/scc/scc_dev_z8530.c		optional scc
> dev/sdhci/sdhci.c		optional sdhci
> dev/sdhci/sdhci_fdt.c		optional sdhci fdt
> dev/sdhci/sdhci_fdt_gpio.c	optional sdhci fdt gpio
> +dev/sdhci/sdhci_fsl_fdt.c	optional sdhci fdt gpio

This looks wrong. It should be using an NXP specific option, not gpio.

Andrew=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?874D5323-F0DB-44E9-8779-7C18832A98B4>