From owner-freebsd-current  Mon Feb 17 10:36:01 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id KAA04710
          for current-outgoing; Mon, 17 Feb 1997 10:36:01 -0800 (PST)
Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.50])
          by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id KAA04689
          for <freebsd-current@freefall.freebsd.org>; Mon, 17 Feb 1997 10:35:57 -0800 (PST)
Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id LAA09397; Mon, 17 Feb 1997 11:33:21 -0700
From: Terry Lambert <terry@lambert.org>
Message-Id: <199702171833.LAA09397@phaeton.artisoft.com>
Subject: Re: mount and df
To: jkh@time.cdrom.com (Jordan K. Hubbard)
Date: Mon, 17 Feb 1997 11:33:21 -0700 (MST)
Cc: chuckr@glue.umd.edu, bde@FreeBSD.ORG, freebsd-current@freefall.freebsd.org
In-Reply-To: <15416.856131916@time.cdrom.com> from "Jordan K. Hubbard" at Feb 16, 97 02:25:16 pm
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> > Both seem broken here.  Neither can find the size of the struct ufs_args,
> > which I found in sys/ufs/ufs/ufsmount.h.  I don't know if this should be
> > directly included in mount.c and df.c, or whether it's supposed to be
> 
> This problem happens with a lot of things which attempt to get at the
> foo_args structures (ufs_args, iso_args, msdosfs_args, etc).  Just try
> building /usr/src/release/sysinstall in -current to watch about 4
> instances of this error.
> 
> Probably only Bruce would know if:
> 
> 	a) These should be coming in via sys/mount.h, like they used to
> 	   (though it was pretty gross to have to define things like
> 	   MSDOSFS to get msdosfs_args in scope).
> 
> 	b) We should be including <foofs/foofs/foo.h> instead.

The mount code should not be doing this; the df code shouldn't either.

If you relocate the headers to some bizarre place, at least pick a common
bizarre place, like /usr/include/sys/fs/ffs_extern.h.

Otherwise change the mount interface to fix the problem the right way.


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.