From owner-cvs-src@FreeBSD.ORG Wed Jul 2 10:42:13 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE70A37B401 for ; Wed, 2 Jul 2003 10:42:12 -0700 (PDT) Received: from mail.speakeasy.net (mail8.speakeasy.net [216.254.0.208]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6828243FD7 for ; Wed, 2 Jul 2003 10:42:11 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 17042 invoked from network); 2 Jul 2003 17:42:10 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 2 Jul 2003 17:42:10 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h62Hg8GI078592; Wed, 2 Jul 2003 13:42:08 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <2249.1057166619@critter.freebsd.dk> Date: Wed, 02 Jul 2003 13:42:21 -0400 (EDT) From: John Baldwin To: Poul-Henning Kamp cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/sys/nfsclient nfs_nfsiod.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2003 17:42:13 -0000 On 02-Jul-2003 Poul-Henning Kamp wrote: > In message <20030702101716.E90143@root.org>, Nate Lawson writes: >>On Wed, 2 Jul 2003, Poul-Henning Kamp wrote: >>> Change idle sleep indentifier to "-" for nfsiod >>> >>> Revision Changes Path >>> 1.78 +1 -1 src/sys/nfsclient/nfs_nfsiod.c >> >>I'm ok with changing to a single character for the default sleep state but >>"-" is the same as a running process. For example: >> >> 1000 90138 90136 2 18 0 1780 1364 pause Ss p0 0:00.10 -tcsh >> 1000 90210 90138 2 28 0 440 196 - R+ p0 0:00.00 ps axl >> >>As you can see, without looking at the run field, it doesn't immediately >>jump out at you which processes are asleep where the "pause" above >>definitely does. How about something like "+" or "*"? > > ...but as you can see, the sleeping processes lack the (R)unning flag. > > I don't care one iota what the string is, I simple went with '-' because > the interrrupt threads already used that. No, they don't use that. You must have missed my earlier email. Ithreads block not in SSLEEP (or TDI_SLEEP) but in SWAIT, a different state altogether. That state has no associated sleep channel, so ps prints the default '-'. I don't mind '-', but I hadn't thought about the running process problem earlier. Perhaps "idle"? Then ps and top could perhaps be taught to use "idle" for mwchan of threads in TDI_WAIT? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/