From owner-freebsd-current@freebsd.org Sun Oct 22 17:31:39 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E318BE2B79B for ; Sun, 22 Oct 2017 17:31:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D41D6E657 for ; Sun, 22 Oct 2017 17:31:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22a.google.com with SMTP id e89so17850563ioi.11 for ; Sun, 22 Oct 2017 10:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iEEzX1q9r2MRRjoC15twtpEE1UgT0MVHMjmLNDG4LB0=; b=d0eNoiKf8lgeILJ1hVvXWwcp8OKUQ8wFup2L2365Dn1hvhTV6p5knyOS1Pv+Ki4nf2 VQp9cZi1JdDmoFbonomC1LK+tKbwew6s+DoOlkwi7/IuFSUTDlo84xqVZ4pAsuUPWk2k uvy/lJayZKHz/21FD2HDUhNn7VT2khN49Vlv1Lh5IfTQ1fMKL1mJzKc67WESRvsFIy9A ngjmd1POwBo7CP4RkkTjmAqZJPHtTbhrvf9Va+qwUHcWF43dq7fbMmxrS1K3mRFLyo7V ZmrK/S+jldFhJP2SI7tompRagdkOlEmZps8sJ1uSidRYd16MWaaYpbCJVzUWsNmrBK7e QOZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iEEzX1q9r2MRRjoC15twtpEE1UgT0MVHMjmLNDG4LB0=; b=ckbTvYSZnslCu6HL2FntGMPtBLS+U2ZWft5FugWxdfEIER5awryMXfn5XPMd2AYhMo NENpQttmVuLV8o1SE+ndKxS9H0pa7QdJmQHrj3V3m2T2PrAIff+1aRGWnk4YCDXK3Bpi OMiv99xSAqWJjgcbfUBJvzoMVXWvWsWfX4xiNDJ5XnwaxA3qtuUU3YovIXC36GCVz3HO ILZFVAziG/BZSMuTIDsdT9x8Pt9dk0vHUabKyzvoCXJVfnNvWRAWfH2AiFgANcnbL/oF VtLfIvQSl3D0JAelvFujsPC5bCkPCRCzAmbjtBxitiOq+NDpUXJt9t+goxs3xvFqrkna n2aQ== X-Gm-Message-State: AMCzsaUfQMc5hEYKMmPTIsSX0gsQWgRzpRBymvhjMQvTGxRGC6f+pwdi xoxSGK0Uh0avX88Pn8YaPHYvKVUCbEkBLctZyexYxw== X-Google-Smtp-Source: ABhQp+TuM2h2KS2+63SjsIl2mIwzQwn7THLDtHqcG8Dx0aHQV9ZXNWzYXfFp3YpzpW5zL7sDZFqYV7DViiEBnS2zxxg= X-Received: by 10.107.30.73 with SMTP id e70mr13621035ioe.130.1508693498982; Sun, 22 Oct 2017 10:31:38 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Sun, 22 Oct 2017 10:31:38 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:df5:793f:4458:5cf6] In-Reply-To: <20171022185328.01dc6fff@ernst.home> References: <20171021084104.517ba6b7@ernst.home> <948b8477-8ef2-9a6f-b9f8-83f515e44b9f@freebsd.org> <20171022093932.4e822050@ernst.home> <20171022185328.01dc6fff@ernst.home> From: Warner Losh Date: Sun, 22 Oct 2017 11:31:38 -0600 X-Google-Sender-Auth: KkvClPM4-IFjx-BsWmy5oiME6dk Message-ID: Subject: Re: /sys/boot compile broken To: gljennjohn@gmail.com Cc: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2017 17:31:40 -0000 On Sun, Oct 22, 2017 at 10:53 AM, Gary Jennejohn wrote: > On Sun, 22 Oct 2017 08:59:52 -0600 > Warner Losh wrote: > > > On Sun, Oct 22, 2017 at 1:39 AM, Gary Jennejohn > > wrote: > > > > > On Sat, 21 Oct 2017 09:33:41 -0600 > > > Warner Losh wrote: > > > > > > > On Oct 21, 2017 8:02 AM, "Allan Jude" wrote: > > > > > > > > On 2017-10-21 02:41, Gary Jennejohn wrote: > > > > > SVN for HEAD source at 324810. > > > > > > > > > > Compiling /sys/boot is totally screwed up. The failure is that > > > > > geliboot.c cannot be found. > > > > > > > > > > This prevents a successful ``make buildworld''. > > > > > > > > > > This error occurs despite the fact that I have > LOADER_NO_GELI_SUPPORT > > > > > set to yes in src.conf. > > > > > > > > > > Looking at the various Makefiles this option is supposed to prevent > > > > > using GELI. > > > > > > > > > > Even if the user wanted to use GELI the compile of the boot code > > > > > would probably fail. > > > > > > > > > > imp@ has had his fingers in the boot code lately. > > > > > > > > > > > > > Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no > > > > > > > > And so you ended up with some code not guarded. Add the additional > > > > src.conf knob for now, and Warner will get it fixed up > > > > > > > > > > > > I fly back from legoland today and will touch this up. I'm in the > process > > > > of changing them into real config knobs from the weird things that > have > > > > leaked out... sys/boot is likely moving my up to boot as well in the > near > > > > future. > > > > > > > > > > Thanks for the info. > > > > > > I see that this change was made fairly late in my time zone. > > > > > > mine too :) I was going to reply to this thread, but it was too late... > > > > Please let me know if it works for you. I was able to do builds both > ways. > > > > It worked. It was good to see that you put an entry in UPDATING. > People noticing was a good clue I'd been remiss in the initial round of commits. Warner