From owner-p4-projects@FreeBSD.ORG  Tue Nov 13 00:25:27 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 179C516A418; Tue, 13 Nov 2007 00:25:27 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B68816A419
	for <perforce@FreeBSD.org>; Tue, 13 Nov 2007 00:25:26 +0000 (UTC)
	(envelope-from zec@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7C4CC13C494
	for <perforce@FreeBSD.org>; Tue, 13 Nov 2007 00:25:26 +0000 (UTC)
	(envelope-from zec@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lAD0PQkm070394
	for <perforce@FreeBSD.org>; Tue, 13 Nov 2007 00:25:26 GMT
	(envelope-from zec@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lAD0PQsM070391
	for perforce@freebsd.org; Tue, 13 Nov 2007 00:25:26 GMT
	(envelope-from zec@FreeBSD.org)
Date: Tue, 13 Nov 2007 00:25:26 GMT
Message-Id: <200711130025.lAD0PQsM070391@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zec@FreeBSD.org using -f
From: Marko Zec <zec@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 129005 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Nov 2007 00:25:27 -0000

http://perforce.freebsd.org/chv.cgi?CH=129005

Change 129005 by zec@zec_tpx32 on 2007/11/13 00:24:48

	When detaching an ifnet, attempt to detach from any vlan,
	bridge, lagg or similar ifnets linked to us as early as
	possible.
	
	This fixes a panic that can be provoked as follows:
	
	ngctl mkpeer eiface ether ether
	ifconfig vlan create
	ifconfig vlan0 vlan 1 vlandev ngeth0
	ifconfig vlan0 10.0.0.1 up
	ngctl shut ngeth0:
	
	The panic is reproducible both in HEAD and vimage branch.
	
	Reported by: Nikos Vassiliadis <nvass at teledomenet.gr>

Affected files ...

.. //depot/projects/vimage/src/sys/net/if.c#22 edit

Differences ...

==== //depot/projects/vimage/src/sys/net/if.c#22 (text+ko) ====

@@ -766,6 +766,14 @@
  	struct ifnet *iter;
  	int found = 0;
 
+	/*
+	 * Detach from any vlan, bridge or lagg ifnets linked to us.
+	 * A small though unlikely window for a race from here to ifp
+	 * unlinking from ifnet list is possible, hence we repeat the
+	 * procedure once again further bellow.  XXX.
+	 */
+	EVENTHANDLER_INVOKE(ifnet_departure_event, ifp);
+
 	IFNET_WLOCK();
 	TAILQ_FOREACH(iter, &V_ifnet, if_link)
 		if (iter == ifp) {