From owner-cvs-src@FreeBSD.ORG  Wed Aug  6 13:28:13 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 167AE37B401
	for <cvs-src@FreeBSD.org>; Wed,  6 Aug 2003 13:28:13 -0700 (PDT)
Received: from mail26a.sbc-webhosting.com (mail26a.sbc-webhosting.com
	[216.173.237.164])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3E14143F75
	for <cvs-src@FreeBSD.org>; Wed,  6 Aug 2003 13:28:11 -0700 (PDT)
	(envelope-from alc@imimic.com)
Received: from www.imimic.com (64.143.12.21)1-0649311686;
	Wed,  6 Aug 2003 16:28:07 -0400 (EDT)
Sender: alc@FreeBSD.ORG
Message-ID: <3F3164D8.17704FF1@imimic.com>
Date: Wed, 06 Aug 2003 15:28:08 -0500
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Gallatin <gallatin@cs.duke.edu>
References: <200308061846.h76IkmYp068237@repoman.freebsd.org>
	<20030806162243.A91712@grasshopper.cs.duke.edu>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
X-Loop-Detect: 1
cc: Alan Cox <alc@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 pmap.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Aug 2003 20:28:13 -0000

Andrew Gallatin wrote:
> 
> Alan Cox [alc@FreeBSD.org] wrote:
> > alc         2003/08/06 11:46:48 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/i386/i386        pmap.c
> >   Log:
> >   Acquire the page queues lock in pmap_insert_entry().  (I used to believe
> >   that the page's busy flag could be relied upon to synchronize access to the
> >   pv list.  I don't any longer.  See, for example, the call to
> >   pmap_insert_entry() from pmap_copy().)
> 
> Any chance this is what's causing the pmap corruption on alpha and ia64?
> We're also doing those same 3 lines there:
> 
>       TAILQ_INSERT_TAIL(&pmap->pm_pvlist, pv, pv_plist);
>       TAILQ_INSERT_TAIL(&m->md.pv_list, pv, pv_list);
>       m->md.pv_list_count++;
> 

Yup.  Give it a try.

> FWIW,  I've managed to get a j16 buildworld to complete on a July 4
> kernel, and fail with a fault-on-nofault-entry panic with a July 10
> kernel.
> 

Prior to the "no fault", I would expect that a zero-filled page got
instantiated to satisfy the fault.

Alan