From nobody Tue Jun 10 03:02:02 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bGYVQ4K6Jz5yx9v; Tue, 10 Jun 2025 03:02:06 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bGYVQ3260z4FdW; Tue, 10 Jun 2025 03:02:06 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749524526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DcNlAqpu7LzdABVgxzISHQz+i8c5XCYra+EMTfIqp28=; b=QtdED4QmhvxEI5BvlO9NWUE2n1xfZxCMVGglXwDDkLB+Z2IR6UXoL4wtTnFLqWusWQm1dK qZ1d5hRVxrn9F9IwMnbnv3YkW2lTkL3+kpzTtWjX9IC+GniUHtW/7CCbmcFhvq9vBzcapM 856iThU2VLC8v6LHFBojU/dFbPt4e/jeQIByXWcBEM4mkReOdlf3Nc7LxlZ7Jldjg7Bbxy t68nsq1bhIrDkD2wY9laR8WgUxvEdNp65v+rMK0mSm3PA2aMWAX61HDczrZdIaPdgYiRJS j2K2um9O9AVWoUp/wYBtwMH/OasjyanVApIEE9F/G0x5LSAaA/MYW9HGxDMg+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749524526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DcNlAqpu7LzdABVgxzISHQz+i8c5XCYra+EMTfIqp28=; b=crZ2flBJgGiRTbmVCnFAivNQtyINvzpnRbB7vaMkjClafOnldGC96gqWu9FRZRXboPsSmG zSYIzNpu2DZxI3J5RMrO+LnUiBX7sPSa6y0GGUsq7rBiHYasHgduohQpm8vwfXY/D4n1SC oEWkpoHDMbjvaX1hVlpnoj8SVzi88YeYxhNjpD4+hcRFeT7ymHIkpD5IlRdSKdUeUCjMg+ ylwj/75vUoQ4rfs5uuzAVnsaLcqLdy9Bj6U3yRVPM8xhDV/uCHWCmRQaLqfvREKSSfFRlO CtyP0wz0hyI2E1aYS9MMaFMcTOsJenmsPp6idmu+rmOO7E1JG1XKcKTMqARNgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749524526; a=rsa-sha256; cv=none; b=ufKRcDcQwKoBGMacqLK7eoddf52QLdmK0Y2VTY4XGkiBlJBBzt67lCUkStvpE58I68sAk/ 4SXi//VYU15mw3Bbmyq6lgPt+3CRNDxrdqPfNidDtSuziFiyZOec7teUazmCO6EcpYRJan 3Dy1GIwb21LjYSkKtlDPdY4pnQ0F8mkpyCTvsPE5xu+Qb7QJwsaK1qFo4o+RvKxTPBxJpS VUa+1QwCXBdpuIRRbYZLgb/VL0iIILsu/oVN28C9QJRe3QGsyWiwy9qeUVJgVo+IQXuT2X OIpX/wtAF8uzhhKEL3VlZhMYnCyQKdJPUfZLkaV/StUyepy4T8AO5I9bz+QIAQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bGYVP4V0pz1p1; Tue, 10 Jun 2025 03:02:05 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 9 Jun 2025 20:02:02 -0700 From: Gleb Smirnoff To: Konstantin Belousov Cc: Rick Macklem , Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. Message-ID: References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 10, 2025 at 03:17:26AM +0300, Konstantin Belousov wrote: K> > R> My vague recollection (I'll admit I cannot be bothered looking at the K> > R> older code) K> > R> is that rpcbind would accept queries on a AF_LOCAL (unix domain) socket for K> > R> local RPC processes. K> > R> K> > R> glebius@ does not want RPCs to be done over AF_LOCAL sockets (he would K> > R> have to explain why), so he created an RPC layer in the krpc for netlink as an K> > R> alternative and converted all utilities that were doing RPCs over AF_LOCAL K> > R> sockets to use it. K> > K> > Not exactly. I don't want kernel RPC to userland to use AF_LOCAL. A process to K> > a process RPC of course continues to use AF_LOCAL. K> > K> > What would be better for rpcbind: to skip providing kernel RPC services if K> > krpc(4) not detected at startup, or to autoload krpc? The latter makes it safe K> > for a scenario when NFS is instantiated at a later runtime of a machine, when K> > rpcbind already runs. The former scenario would require a restart of rpcbind. K> > K> K> IMO rpcbind must not load any modules. It should communicate with krpc if K> available. K> K> The krpc load is the global system policy decision, it should be handled K> in rc scripts, as it is common for such decisions. The loading would be K> enabled if some component requires krpc, which means if nfsd enabled. K> It would be ordered before rpcbind startup, of course. My only concern is that it would require restart of rpcbind, if sysadmin decides to configure NFS later after startup. -- Gleb Smirnoff