From owner-freebsd-current@FreeBSD.ORG Fri Aug 31 08:43:49 2012 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D150D1065674; Fri, 31 Aug 2012 08:43:49 +0000 (UTC) (envelope-from dimitry@andric.com) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 8949C8FC19; Fri, 31 Aug 2012 08:43:49 +0000 (UTC) Received: from [192.168.0.6] (spaceball.home.andric.com [192.168.0.6]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B883E5C37; Fri, 31 Aug 2012 10:43:47 +0200 (CEST) Message-ID: <50407947.50907@andric.com> Date: Fri, 31 Aug 2012 10:43:51 +0200 From: Dimitry Andric User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20120828 Thunderbird/16.0 MIME-Version: 1.0 To: deeptech71@gmail.com References: <504068F2.6010300@gmail.com> In-Reply-To: <504068F2.6010300@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org Subject: Re: sys/dev/amr build error with Clang X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2012 08:43:49 -0000 On 2012-08-31 09:34, deeptech71@gmail.com wrote: > /usr/src/sys/modules/amr/../../dev/amr/amr.c:970:1: error: function > 'amr_periodic' is not needed and will not be emitted > [-Werror,-Wunneeded-internal-declaration] The one call to get the callout to amr_periodic() started seems to have been commented out in r239912: http://svnweb.freebsd.org/base/head/sys/dev/amr/amr.c?r1=239912&r2=239911&pathrev=239912 If the function isn't necessary anymore, it could just be deleted, or #ifdef'd out.