From owner-cvs-src@FreeBSD.ORG Thu Mar 30 08:59:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84C0216A400; Thu, 30 Mar 2006 08:59:10 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id E954243D4C; Thu, 30 Mar 2006 08:59:09 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 950002096; Thu, 30 Mar 2006 10:59:03 +0200 (CEST) X-Spam-Tests: AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Learn: ham X-Spam-Score: -2.4/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id 150D72081; Thu, 30 Mar 2006 10:59:03 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id DE92933C31; Thu, 30 Mar 2006 10:59:02 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Daniel Eischen References: <200603290420.k2T4KsNs095600@repoman.freebsd.org> Date: Thu, 30 Mar 2006 10:59:02 +0200 In-Reply-To: <200603290420.k2T4KsNs095600@repoman.freebsd.org> (Daniel Eischen's message of "Wed, 29 Mar 2006 04:20:54 +0000 (UTC)") Message-ID: <86k6actijt.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/librt sigev_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2006 08:59:10 -0000 Daniel Eischen writes: > Log: > Account for recent changes in namespace.h. Use _pthread_create > instead of pthread_create. I'm not sure this is correct. When we're inside libpthread or libthr, we want to use the underscore versions of pthread_*() so we're sure that we're referring to ourself and not to some third-party pthred library that may have been mixed in somehow, but outside of it, we want to refer to whichever pthread library the application developer has chosen to use (he may even have his own compiled into the application - been there, done that). I believe the correct fix in this case is to move below "un-namespace.h". DES --=20 Dag-Erling Sm=F8rgrav - des@des.no