From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep 13 01:40:23 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD7F216A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Sep 2004 01:40:23 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BF35043D2D
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Sep 2004 01:40:23 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8D1eNVb062232
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 13 Sep 2004 01:40:23 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8D1eNfl062228;
	Mon, 13 Sep 2004 01:40:23 GMT
	(envelope-from gnats)
Date: Mon, 13 Sep 2004 01:40:23 GMT
Message-Id: <200409130140.i8D1eNfl062228@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dan Lukes <dan@obluda.cz>
Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dan Lukes <dan@obluda.cz>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2004 01:40:23 -0000

The following reply was made to PR bin/71618; it has been noted by GNATS.

From: Dan Lukes <dan@obluda.cz>
To: Giorgos Keramidas <keramida@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code
Date: Mon, 13 Sep 2004 03:37:11 +0200 (CEST)

 On Sun, 12 Sep 2004, Giorgos Keramidas wrote:
 
 >> - 		fprintf(fd, "%s %d %-6u (%ld,%ld) %-15s %s\n",
 >> + 		fprintf(fd, "%s %d %-6u (%d,%d) %-15s %s\n",
 >
 > There's no guarantee that an int32_t value will be defined with an `int'.
 > This might result in unexpected truncation of the printed value.  A better
 
  	True. In the fact, I miss the existence of 'j' modifier and intmax_t
 type.
 
 > of work, can you try the following (and see if you can come up with fixes
 > for the warnings this shows)?
 >
 > 	# cd /usr/src/usr.sbin/timed/
 > 	# make NO_WERROR=1 WARNS?=3
 
  	I'm compiling with -Wall -O3.
  	It seems to be more than any WARNS=X
 
  	If there are some warning not corrected by attached patches, then it
 mean I'm don't know how the good way to correct it.
 
 > Thank you for your work so far :-)
 
  	I have a lot of spare time now only ... ;-)
  								Dan