From nobody Wed Aug 23 14:23:50 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RW7kG53v7z4qh4T for ; Wed, 23 Aug 2023 14:23:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RW7kG3lSdz3Yfp for ; Wed, 23 Aug 2023 14:23:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692800630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ljs9t06WJG+2wD7oiA+/vBXWTaLbSKnPvLop700zmyc=; b=m0ZFzPgdoYg8AeLYwPtjlBlJb+7zEHKb3YaVbidChQhp/PfayrNgxyqDgknOm842RuCkWX dNOGHmnuy9EqCu2wjwFJ4gaUS5pMq6MP99+veOwzhXv8O8ynoGdJ152p/Y76JlaGUgv8BW rVffcIgyX5Pfwu9sbI4BmYJ9EFiQQBjdcZy+6s38q4qDqqhAtsuIw78WsJGMCr0lvgMbW8 82uLwxGh7wVy35c8jk4wc973CTspcjUfLlew2A4j4TlH9nJnfc399qRrG7N7CYJCI9g2pz CxUrrTNJYYlQs2eSwDC/1nAFV0RTGUTWEFzb6YszujQsh87P/JaPwwTtXt8yuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692800630; a=rsa-sha256; cv=none; b=jhjiGeeVsIqpqDvGcs2Zmc6IASSOhyjgdbaS6GyYwo5DjA7n3inx5h5qWBDC5+YFARNYYq rUvJOIcRsJcr+XRLL3QNWs+tyCGI9xuhqqaK8eS2PoTKa1/iAqjB6c401wwNSm037njGij 8PRrjMqmb3pC/3ZjhjVRVWEf6qDyGDUXnHw11+ugOPgdiEsHbXbgq+Z0A7PGiOPEZey9ks W5CnrdfsExmDkxsgeRRGMgiaH6RtHdMDh61pm3ynmlgY0jfs6GGApDVBIWFYGk2ertAcUC iRUbNDT/3qZEJAdeSZc4ngLlLAKQkJCjBNUqhJL+dk4oG+h8+5bBOxMTC+BZ2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RW7kG2rC5zp8H for ; Wed, 23 Aug 2023 14:23:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37NENoP0065185 for ; Wed, 23 Aug 2023 14:23:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37NENoSl065184 for bugs@FreeBSD.org; Wed, 23 Aug 2023 14:23:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273289] smartpqi: fix panic on removal of SAS drive Date: Wed, 23 Aug 2023 14:23:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273289 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bcr@FreeBSD.org, | |markj@FreeBSD.org Status|New |Open --- Comment #2 from Mark Johnston --- (In reply to John F. Carr from comment #1) Yes, there doesn't seem to be any particular reason to hold the lock across= the free() calls. Though, I cannot see a reason to use a MTX_SPIN lock here at all. It looks like softs->devlist_lock should be a MTX_DEF mutex. Spin mutexes are only needed when synchronizing with interrupt handlers, and it doesn't look like this mutex has to deal with that. Though, fixing that would be more involv= ed and would require some modification to this OS abstraction layer in the dri= ver. --=20 You are receiving this mail because: You are the assignee for the bug.=