Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Feb 2002 18:03:37 -0600
From:      Maxime Henrion <mux@sneakerz.org>
To:        freebsd-arch@freebsd.org
Cc:        Brooks Davis <brooks@one-eyed-alien.net>
Subject:   Re: Patches to if_loop + the interface cloning framework
Message-ID:  <20020212180337.D25374@sneakerz.org>
In-Reply-To: <20020212155646.A26408@Odin.AC.HMC.Edu>; from brooks@one-eyed-alien.net on Tue, Feb 12, 2002 at 03:56:46PM -0800
References:  <20020212154828.A25374@sneakerz.org> <20020212143909.B24768@Odin.AC.HMC.Edu> <20020212165544.B25374@sneakerz.org> <20020212153609.D24768@Odin.AC.HMC.Edu> <20020212174453.C25374@sneakerz.org> <20020212155646.A26408@Odin.AC.HMC.Edu>

next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis (brooks@one-eyed-alien.net) wrote:
> On Tue, Feb 12, 2002 at 05:44:53PM -0600, Maxime Henrion wrote:
> > 
> > I've updated the patch at the same location, adding a panic() in case
> > the creation of lo0 fails.  I'll be interested in removing the KLD
> > stuff from this file since it's not working anyway, and adds some error
> > checking, but that will be a bit later ;-)
> 
> Looks good though error checking would be nice. ;-)

Actually, after taking a closer look at it, there is no error checking
that can be done in locreate().  It calls if_attach() and bpfattach()
which are both void functions and calls malloc() with M_WAITOK.  Were
you talking about something else ?

> I'm not convinced
> that removing the module support is a good idea.  I'd much rather move
> in the other direction in general.

What would it be useful to, if the kernel can't link without it ?

Thanks,
Maxime Henrion

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020212180337.D25374>