From owner-freebsd-ports@FreeBSD.ORG Fri Jul 25 13:07:36 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 774891065672 for ; Fri, 25 Jul 2008 13:07:36 +0000 (UTC) (envelope-from chukharev@mail.ru) Received: from mx2.mail.ru (mx2-2.mail.ru [194.67.23.122]) by mx1.freebsd.org (Postfix) with ESMTP id E4E898FC0C for ; Fri, 25 Jul 2008 13:07:35 +0000 (UTC) (envelope-from chukharev@mail.ru) Received: from [130.230.40.65] (port=51288 helo=localhost) by mx2.mail.ru with asmtp id 1KMN1B-000DDC-00; Fri, 25 Jul 2008 17:07:33 +0400 Date: Fri, 25 Jul 2008 16:09:10 +0300 To: "Dirk Meyer" , freebsd-ports@freebsd.org From: "V.Chukharev" Content-Type: multipart/mixed; boundary=----------0VGlgWoVpBpJwBN94AoEPg MIME-Version: 1.0 References: <08GlBzRclM@dmeyer.dinoex.sub.org> Message-ID: In-Reply-To: <08GlBzRclM@dmeyer.dinoex.sub.org> User-Agent: Opera Mail/9.51 (FreeBSD) X-Spam: Not detected X-Mras: OK Cc: Subject: Re: Mk/bsd.openssl.mk optimization X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2008 13:07:36 -0000 ------------0VGlgWoVpBpJwBN94AoEPg Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit On Fri, 25 Jul 2008 07:30:18 +0300, Dirk Meyer wrote: > V.Chukharev schrieb:, > >> I should confess I do not understand how my patch works. I expected to see a >> file /usr/ports/.openssl_installed or /tmp/index_something/.openssl_installed >> or similar, but could not see it... But I hope this patch will inspire you >> to do something really working. > > This patch breaks the desired funtion. Yes, it does break things. It was intended only to demonstrate how big can be the speedup. I have mentioned I know very little about make. > To speedup index build you can add in in your /etc/make.conf > WITH_OPENSSL_BASE=yes > or > WITH_OPENSSL_PORT=yes That's great! And is it possible to set some default value on installation, and make each corresponding port change it accordingly? I mean, is there a procedure to ensure ports do such changes? > The linker will pull in the latests version of libssl.so, > So this check is necessary to detect an installed port version, > and record the correct dependency. Yes. Only, the detection can be done once per an index build. > The result can be cached only if no other ports or package is installed. You mean, my patch did not delete the cache at the end of the index build? That's true. The patch was not a real one... > So you are right that make index could be otimized, > but it will take much more work. Totally agree on this. I tryed to make caching in bsd.subdir.mk as Kris proposed, and I got also considerable speedup, but not as good as with the first patch. The grep on all packages is done once per port category. I miss how to pass the results to a child make... Anyway, I attach the new (better, but still not fully working) patch JFYI. > kind regards Dirk > > - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany > - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org] > http://people.freebsd.org/~dinoex/errorlogs/ > Best regards, -- V. Chukharev ------------0VGlgWoVpBpJwBN94AoEPg Content-Disposition: attachment; filename=Mk_bsd.openssl.mk_1.patch Content-Type: application/octet-stream; name=Mk_bsd.openssl.mk_1.patch Content-Transfer-Encoding: Base64 LS0tIC91c3IvcG9ydHMvTWsvYnNkLm9wZW5zc2wubWsub3JpZwkyMDA4LTA3LTIz IDA5OjE0OjI5LjAwMDAwMDAwMCArMDMwMAorKysgL3Vzci9wb3J0cy9Nay9ic2Qu b3BlbnNzbC5tawkyMDA4LTA3LTI1IDEyOjAyOjAxLjAwMDAwMDAwMCArMDMwMApA QCAtMzMsNiArMzMsOSBAQAogIyBCVUlMRF9ERVBFTkRTCQktIGFyZSBhZGRlZCBp ZiBuZWVkZWQKICMgUlVOX0RFUEVORFMJCS0gYXJlIGFkZGVkIGlmIG5lZWRlZAog CisuaWYgIWRlZmluZWQoQlNEX09QRU5TU0xfTUspCitCU0RfT1BFTlNTTF9NSz15 ZXMKKwogT3BlblNTTF9JbmNsdWRlX01BSU5UQUlORVI9CWRpbm9leEBGcmVlQlNE Lm9yZwogCiAjIGhvbm9yIG9ic29sZXRlIG9wdGlvbnMgZm9yIGEgYml0CkBAIC0x MjEsMTMgKzEyNCwxOSBAQAogCWV4aXN0cygke0RFU1RESVJ9LyR7TE9DQUxCQVNF fS9saWIvbGliY3J5cHRvLnNvKQogIyBmaW5kIGluc3RhbGxlZCBwb3J0IGFuZCB1 c2UgaXQgZm9yIGRlcGVuZGVuY3kKIFBLR19EQkRJUj89CQkke0RFU1RESVJ9L3Zh ci9kYi9wa2cKKy5pZiAhZGVmaW5lZChPUEVOU1NMX0lOU1RBTExFRCkKIE9QRU5T U0xfSU5TVEFMTEVEIT0JZ3JlcCAtbCAtciAiXmxpYi9saWJzc2wuc28uIiAiJHtQ S0dfREJESVJ9IiB8IFwKIAkJCXdoaWxlIHJlYWQgY29udGVudHM7IGRvIFwKIAkJ CQlzc2xwcmVmaXg9YGdyZXAgIl5AY3dkICIgIiQke2NvbnRlbnRzfSIgfCAke0hF QUR9IC1uIDFgOyBcCiAJCQkJaWYgdGVzdCAiJCR7c3NscHJlZml4fSIgPSAiQGN3 ZCAke0xPQ0FMQkFTRX0iIDsgdGhlbiBcCiAJCQkJCWVjaG8gIiQke2NvbnRlbnRz fSI7IGJyZWFrOyBmaTsgZG9uZQorLmVuZGlmCisuaWYgIWRlZmluZWQoT1BFTlNT TF9QT1JUKQogT1BFTlNTTF9QT1JUIT0JCWdyZXAgIl5AY29tbWVudCBPUklHSU46 IiAiJHtPUEVOU1NMX0lOU1RBTExFRH0iIHwgJHtDVVR9IC1kIDogLWYgMgorLmVu ZGlmCisuaWYgIWRlZmluZWQoT1BFTlNTTF9TSExJQkZJTEUpCiBPUEVOU1NMX1NI TElCRklMRSE9CWdyZXAgIl5saWIvbGlic3NsLnNvLiIgIiR7T1BFTlNTTF9JTlNU QUxMRUR9IgorLmVuZGlmCiBPUEVOU1NMX1NITElCVkVSPz0JJHtPUEVOU1NMX1NI TElCRklMRTpFfQogLmVuZGlmCiBPUEVOU1NMX1BPUlQ/PQkJc2VjdXJpdHkvb3Bl bnNzbApAQCAtMTY4LDMgKzE3Nyw0IEBACiAjIyMgY3J5cHRvCiAjUkVTVFJJQ1RF RD0JCSJDb250YWlucyBjcnlwdG9ncmFwaHkuIgogCisuZW5kaWYKLS0tIC91c3Iv cG9ydHMvTWsvYnNkLnBvcnQuc3ViZGlyLm1rLm9yaWcJMjAwOC0wNy0yMSAxNjow MDozNi4wMDAwMDAwMDAgKzAzMDAKKysrIC91c3IvcG9ydHMvTWsvYnNkLnBvcnQu c3ViZGlyLm1rCTIwMDgtMDctMjUgMTI6MDI6MDEuMDAwMDAwMDAwICswMzAwCkBA IC01Niw2ICs1NiwxMCBAQAogREVTQ1I/PQkJCSR7UEtHRElSfS9wa2ctZGVzY3IK IAogLmluY2x1ZGUgIiR7UE9SVFNESVJ9L01rL2JzZC5jb21tYW5kcy5tayIKKyNj YWNoZSB2YXJpYWJsZXMgZnJvbSBic2Qub3BlbnNzbC5taworLmlmICFkZWZpbmVk KEJTRF9PUEVOU1NMX01LKQorLmluY2x1ZGUgIiR7UE9SVFNESVJ9L01rL2JzZC5v cGVuc3NsLm1rIgorLmVuZGlmCiAKIC5NQUlOOiBhbGwKIAo= ------------0VGlgWoVpBpJwBN94AoEPg--