From owner-freebsd-current@FreeBSD.ORG  Wed Sep 25 17:52:11 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A124AABB
 for <freebsd-current@freebsd.org>; Wed, 25 Sep 2013 17:52:11 +0000 (UTC)
 (envelope-from ambrisko@ambrisko.com)
Received: from mail.ambrisko.com (mail.ambrisko.com [70.91.206.90])
 by mx1.freebsd.org (Postfix) with ESMTP id 85EA326A7
 for <freebsd-current@freebsd.org>; Wed, 25 Sep 2013 17:52:11 +0000 (UTC)
X-Ambrisko-Me: Yes
Received: from server2.ambrisko.com (HELO internal.ambrisko.com)
 ([192.168.1.2])
 by ironport.ambrisko.com with ESMTP; 25 Sep 2013 10:55:38 -0700
Received: from ambrisko.com (localhost [127.0.0.1])
 by internal.ambrisko.com (8.14.4/8.14.4) with ESMTP id r8PHqAOR062154
 for <freebsd-current@freebsd.org>; Wed, 25 Sep 2013 10:52:10 -0700 (PDT)
 (envelope-from ambrisko@ambrisko.com)
Received: (from ambrisko@localhost)
 by ambrisko.com (8.14.4/8.14.4/Submit) id r8PHqAIG062153
 for freebsd-current@freebsd.org; Wed, 25 Sep 2013 10:52:10 -0700 (PDT)
 (envelope-from ambrisko)
Date: Wed, 25 Sep 2013 10:52:10 -0700
From: Doug Ambrisko <ambrisko@ambrisko.com>
To: freebsd-current@freebsd.org
Subject: Problem with r255775 include/mk-osreldate.sh
Message-ID: <20130925175210.GA56575@ambrisko.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Sep 2013 17:52:11 -0000

I don't know if others have run into this but I hit a problem with
include/mk-osreldate.sh.  It does a set -e to exit on commands failing
and sources in sys/conf/newvers.sh to get various things set.
In newvers.sh it does a bunch of
	<commmand>
	if [ $? -eq 0 ]; then
to decide what to do when it passes or fails.  Unfortunately, when
it fails due to the "set -e" it just exits and doesn't do the
else clause.  For me I check out a svn tree then build in a chroot.
In the chroot svn was failing then not creating a osreldate.h
resulting in the build dying.  This happened on two different machines
of which I use this method.

Removing the set -e in mk-osreldate.sh "fixed" my problem.  It should
probably be reworked to not depend on set -e and print errors when things
fail.  I guess newvers.sh could be reworked to do
	if <command> ; then
which should pass set -e.

What do folks think?  It would be good to get this fixed before MFC
and before 10 is released.

Doug A.