From owner-freebsd-current@freebsd.org Fri Apr 15 04:19:24 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8B1DAEC499 for ; Fri, 15 Apr 2016 04:19:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8297910C4 for ; Fri, 15 Apr 2016 04:19:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x229.google.com with SMTP id o126so124379442iod.0 for ; Thu, 14 Apr 2016 21:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=/+cKYBeauJ1Khs97EKTRHOjlbrWBsfSKP+4200abCCM=; b=A+g80l/LRaH6sxG8qb6pPS9Zs3spNKsCbPMOpfnwZpQ/FRk9dIurKSP4jZ+TBuuGQ5 QiJK+Mn6fbY9bQfJpnDsthPZJAS3qvRCz/mWesV6ZR6SRt8QEleV6wgoZ6ednV8Lldqw qUptPZwvn51lFsyxapF3sFv0Pxa/4giGunc1MRBuc1teNy0zYVem/In0oIHI2oYdSBrn av2wSiAB6HGMRGkQdlOF2Ii2+/oJHU/SkHfPLlI3fviMptTPtJRvpffF44h+V2Yz+Kwo juu9r2enqBe8Y3kFnmtJL757AkDIuCsfZHnsvfzV4LvQ8DMEFm+WKwmmP21KTbUpa0Yi IEMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=/+cKYBeauJ1Khs97EKTRHOjlbrWBsfSKP+4200abCCM=; b=NByMcnqICstMP7TGQLn0HqaRWbkR6Zw/Uqy0aVYNrjRow1dEQKZTUAfaFkyTY3wr93 18yzBiFG6TRKgoMViCsBb336L77RAEkqrOTYDskDOXMA/U2qznSWgHoEOW1Q10wIxxhT XzJeV2RkzkVgYpcA2em5XMYuCqG7da3+5U3gZfJpooM71CqZmtnlWFrQtZoxis1EE3sL zo5zDajdAUiUw0PbTnLwiaF1lln+pSwYkkwJCBHGjISBiphVwVgg06jUwj5VTLEBjEUc bmy0XfDsXJ7V5YBkFT728hE0f3B0GLccNzjEteMNLAN8faMDqAft1eXOFdVkPke6ZCt1 M5Sg== X-Gm-Message-State: AOPr4FWkoSV2unF+6MCs0yuxZ9bz81yVUEF0G2QqHMKHcIJ6RowkWkhIkggkhsw4qkGnyolquA7V3X3TzlB7Jg== MIME-Version: 1.0 X-Received: by 10.107.137.16 with SMTP id l16mr19563600iod.197.1460693963967; Thu, 14 Apr 2016 21:19:23 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.79.104.197 with HTTP; Thu, 14 Apr 2016 21:19:23 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: References: Date: Thu, 14 Apr 2016 22:19:23 -0600 X-Google-Sender-Auth: OjKt3mrTacNiaSjnOPPwhKO3rjM Message-ID: Subject: Re: Heads up From: Warner Losh To: Warren Block Cc: FreeBSD Current Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 04:19:24 -0000 On Thu, Apr 14, 2016 at 9:56 PM, Warren Block wrote: > On Thu, 14 Apr 2016, Warner Losh wrote: > > The CAM I/O scheduler has been committed to current. This work is described >> in https://people.freebsd.org/~imp/bsdcan2015/iosched-v3.pdf though the >> default scheduler doesn't change the default (old) behavior. >> >> One possible issue, however, is that it also enables NCQ Trims on ada >> SSDs. >> There are a few rogue drives that claim support for this feature, but >> actually implement data corrupt instead of queued trims. The list of known >> rogues is believed to be complete, but some caution is in order. > > > Is the list of drives queryable? Is there an easy way to tell if the > currently-connected drives are on the list? > /usr/src/sys/cam/ata/ata_da.c has the list. dmesg will tell you if it detected a bad one since it prints the drive's quirks. But that's no big deal, because the bad one work just fine if you never issue a NCQ TRIM. This small group of drives were early adapters of this technology Here's the full list of known rogues: Crucial/Micron M500 (all firmware prior to MU07) Micron M510 MU01 firmware (newer firmware is good) Crucial/Micron M550 MU01 firmware (newer firmware is good) Crucial MX100 MU01 firmware (newer firmware is good) FCCT M500 all firmware Samsung 830 all firmware Samsung 840 all firmware Samsung 850 all firmware All of these are at least 18 months old (if not older). There's some confusing in Linux lists on the full impact of the Samsung drives (there was a bug in the Linux implementation (that can't be present in the FreeBSD implementation) that may have been the root cause for the Samsung black listing). Out of an abundance of caution, I've kept them in the list. Also, it's my belief that the Crucial/Micron models with MU01 firmware were mostly corrected after early samples since most of the channel drives I've helped people debug had MU02 firmware. Also, a quick google search shows the MU02 firmware for each of these models has been available for at least a year. Warner