From owner-cvs-ports@FreeBSD.ORG  Sun Jan 15 18:13:52 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A730F1065678;
	Sun, 15 Jan 2012 18:13:52 +0000 (UTC)
	(envelope-from sunpoet@sunpoet.net)
Received: from sunpoet.net (sunpoet.net [220.133.12.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A8B58FC0C;
	Sun, 15 Jan 2012 18:13:52 +0000 (UTC)
Received: by sunpoet.net (Postfix, from userid 1000)
	id 0A44414D6; Mon, 16 Jan 2012 02:13:40 +0800 (CST)
Date: Mon, 16 Jan 2012 02:13:39 +0800
From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To: Yar <yarodin@gmail.com>
Message-ID: <20120115181339.GC45406@bonjour.sunpoet.net>
References: <201201080930.q089UX6D091198@repoman.freebsd.org>
	<8662gfjd02.wl%poyopoyo@puripuri.plala.or.jp>
	<147869552.20120115123504@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <147869552.20120115123504@gmail.com>
Organization: The FreeBSD Project
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: cvs-ports@FreeBSD.org, poyopoyo@puripuri.plala.or.jp, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/archivers/unrar Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jan 2012 18:13:52 -0000

On Sun, Jan 15, 2012 at 12:35:04PM +0600, Yar wrote:
> Hello Poyopoyo,
> 
> Saturday, January 14, 2012, 7:20:45, you wrote:
> 
> > At Sun, 8 Jan 2012 09:30:33 +0000 (UTC),
> > Sunpoet Po-Chuan Hsieh wrote:
> >> @@ -24,6 +24,9 @@ MAKEFILE=     makefile.unix
> >>  PLIST_FILES=   bin/unrar
> >>  PORTDOCS=      license.txt readme.txt
> >> 
> >> +post-patch:
> >> +       @${REINPLACE_CMD} -e '/^CXX/ s|^|#|' ${WRKSRC}/${MAKEFILE}
> >> +
> >>  do-install:
> >>         ${INSTALL_PROGRAM} ${WRKSRC}/unrar ${PREFIX}/bin
> >>  .if !defined(NOPORTDOCS)
> 
> > Hi,
> > Commenting CXX* out after patch phase breaks unrar-iconv since it
> > requires CXXFLAGS to be set in makefile.unix.
> 
> ===>>  Building for unrar-iconv-4.10,5
> > c++  -O2 -pipe -march=native -fno-strict-aliasing
> > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DWITH_ICONV -DUNRAR -c rar.cpp
> > In file included from rar.hpp:5,
> >                  from rar.cpp:1:
> > os.hpp:197:19: error: iconv.h: No such file or directory
> > In file included from rar.hpp:76,
> >                  from rar.cpp:1:
> > global.hpp:19: error: 'iconv_t' does not name a type
> > global.hpp:20: error: 'iconv_t' does not name a type
> > gmake: *** [rar.o] Error 1
> > *** Error code 1
> 
> > Here's a candidate:
> > - Comment CXX* out for only unrar not for unrar-iconv.
> I  vote  for it! \if !defined(USE_ICONV) at unrar Makefile\.
> It's more accuracy at my point of view.
> 
> > - in unrar-iconv do the same thing with files/patch-iconv.
> BUT :) I attached tiny patch for unrar-iconv/Makefile
> with dirty workaround.
> 
> 
> 
> -- 
> Best regards,
>  Yar                          mailto:yarodin@gmail.com

Hi,

I have a suggestion for this build failure.
The patch for makefile.unix in unrar-iconv/files/patch-iconv can be replaced
by the following lines in unrar-iconv/Makefile.

CXXFLAGS+= -DWITH_ICONV -I${LOCALBASE}/include
LDFLAGS+=  -L${LOCALBASE}/lib -liconv

Then, we can remove makefile.unix patch from unrar-iconv/files/patch-iconv.

If you agree with this change, I'll commit it ASAP.
Thanks.

Regards,
sunpoet