From owner-cvs-src@FreeBSD.ORG Wed Oct 12 21:57:31 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3F3816A41F; Wed, 12 Oct 2005 21:57:31 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CCB443D49; Wed, 12 Oct 2005 21:57:31 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9CLsjsL061402; Wed, 12 Oct 2005 15:54:45 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 12 Oct 2005 15:55:52 -0600 (MDT) Message-Id: <20051012.155552.115023057.imp@bsdimp.com> To: ru@freebsd.org From: "M. Warner Losh" In-Reply-To: <20051012191933.GD75270@ip.net.ua> References: <20051012.104300.74694006.imp@bsdimp.com> <20051012170652.GI99170@submonkey.net> <20051012191933.GD75270@ip.net.ua> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp-2 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 12 Oct 2005 15:54:46 -0600 (MDT) Cc: cvs-src@freebsd.org, ceri@submonkey.net, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/make make.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2005 21:57:32 -0000 In message: <20051012191933.GD75270@ip.net.ua> Ruslan Ermilov writes: : On Wed, Oct 12, 2005 at 06:06:52PM +0100, Ceri Davies wrote: : > > From: Ruslan Ermilov : > > Subject: Re: cvs commit: src/usr.bin/make make.1 : > > Date: Wed, 12 Oct 2005 18:27:10 +0300 : > > : > > > On Wed, Oct 12, 2005 at 09:13:30AM -0600, M. Warner Losh wrote: : > > > > In message: <200510121009.j9CA9aE3026075@repoman.freebsd.org> : > > > > Yar Tikhiy writes: : > > > > : yar 2005-10-12 10:09:36 UTC : > > > > : : > > > > : FreeBSD src repository : > > > > : : > > > > : Modified files: : > > > > : usr.bin/make make.1 : > > > > : Log: : > > > > : __MAKE_CONF doesn't really belong here because it is : > > > > : a FreeBSD extension of sys.mk. A xref to make.conf(5) : > > > > : will be enough here. : > > > > : : > > > > : Requested by: ru : > > > > : > > > > I disagree. It is already hard enough to find info about __MAKE_CONF, : > > > > and since it is part of the base system, this seems like an artificial : > > > > distinction. : > > > > : > : > > > We really don't need any more duplication. : > : > That's true, but it should be our problem and not the user's. : > : It's not just that, it's that __MAKE_CONF isn't used/set/known : by the make(1) utility. It's a location of make.conf file that : is included by the default FreeBSD version of sys.mk. So if : we wanted to emphasize this, it'd be more logical to talk more : about make.conf(5) itself, what it is and how it's used in : FreeBSD. It can be a separate section, e.g. "FreeBSD sys.mk", : documenting __MAKE_CONF and probably other "make \ : __MAKE_CONF=/dev/null -f /dev/null -dg1" bits. Or it could be : a short explanation of what make.conf is and then a reference : to the make.conf(5) manpage. But it's certainly not the make's : internal variable (where it was initially documented), hence my : objection to this commit. That's a distinction without a difference. sys.mk is already described in make(1), so things that affect it should also be there. A simple cross reference to make.conf(5) is insufficient. Honestly, I can't see why you are so opposed to having a one-liner for people that people can find. It really should be there. Warner