Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Feb 2016 14:37:22 +0100
From:      Matthieu Volat <mazhe@alkumuna.eu>
To:        Ashish SHUKLA <ashish@FreeBSD.org>
Cc:        ports-list freebsd <freebsd-ports@freebsd.org>
Subject:   Re: [CFT] net-im/ejabberd to 16.01
Message-ID:  <CEC1F737-32E1-478D-A3AB-3473BF14B28F@alkumuna.eu>
In-Reply-To: <864mcs1g9p.fsf@chateau.d.if>
References:  <86h9gs26l0.fsf@chateau.d.if> <20160228193353.0b62c06b@freedom.alkumuna.eu> <864mcs1g9p.fsf@chateau.d.if>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_1E00F30E-FC21-44C8-B2F0-F77B557E39BA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> Le 29 f=C3=A9vr. 2016 =C3=A0 02:01, Ashish SHUKLA <ashish@FreeBSD.org> =
a =C3=A9crit :
>=20
> On Sun, 28 Feb 2016 19:33:53 +0100, Matthieu Volat <mazhe@alkumuna.eu> =
said:
> | On Sun, 28 Feb 2016 21:02:59 +0530
> | ashish@FreeBSD.org (Ashish SHUKLA) wrote:
>=20
> [..]
>=20
> | Thanks for your work,
>=20
> Thank you for taking time to test the diff.
>=20
> | On my 10.2/amd64 host, the build failed due to using <stdint.h> =
types without including it in :
>=20
> |   =
/usr/ports/net-im/ejabberd/work/deps/p1_stringprep/c_src/stringprep.cpp
>=20
> Following changeset from the diff file should fix this:
>=20
> --8<---------------cut here---------------start------------->8---
> diff -urN =
/usr/ports/net-im/ejabberd/files/patch-.._deps_p1__stringprep_c__src_strin=
gprep.cpp =
ejabberd/files/patch-.._deps_p1__stringprep_c__src_stringprep.cpp
> --- =
/usr/ports/net-im/ejabberd/files/patch-.._deps_p1__stringprep_c__src_strin=
gprep.cpp	1970-01-01 05:30:00.000000000 +0530
> +++ ejabberd/files/patch-.._deps_p1__stringprep_c__src_stringprep.cpp	=
2016-02-28 20:11:00.521409079 +0530
> @@ -0,0 +1,10 @@
> +--- ../deps/p1_stringprep/c_src/stringprep.cpp.orig
> ++++ ../deps/p1_stringprep/c_src/stringprep.cpp
> +@@ -19,6 +19,7 @@
> +  */
> +
> + #include <string.h>
> ++#include <libutil.h>
> + #include <erl_nif.h>
> +
> + #include "uni_data.c"
> --8<---------------cut here---------------end--------------->8---
>=20
> Are you sure, the diff was not properly applied. I tried the diff from =
the
> URL, and applied on net-im/ejabberd and seems to have applied fine, =
and it
> builds fine too, on 10.2-RELEASE/amd64

Hmm, I'll be a bit overwhelmed until thursday, I'll check that...

>=20
> | And it seems the pam module is not installed, again?
>=20
> | chmod: /usr/local/lib/erlang/lib/ejabberd-16.01/priv/bin/epam: No =
such file or directory
> | chown: /usr/local/lib/erlang/lib/ejabberd-16.01/priv/bin/epam: No =
such
> | file or directory
>=20
> This is an oversight on my part. Sorry about this. I have updated the =
diff to
> refer to the correct path.
>=20
> https://people.freebsd.org/~ashish/diffs/ejabberd-16.01-01.diff
> sha256 sum: =
7dd1f02da1ccf035f58d857a710787bdc6080d2e2651ca1dd9d1a335a3cc57c8
>=20
> If you could functionally test PAM support as well, that'll be great.

Thanks, there was another blocking issue for me yesterday, which is the =
ejabberdctl is now in bash.

If possible, I'd like to make a patch to (optionally) revert to pure sh, =
as I find it a bit sad to go full bash only to read a few parameters...

I'll keep you informed

>=20
> Thanks!
> --
> Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 =
E74F A4B0
> Sent from my Emacs


--Apple-Mail=_1E00F30E-FC21-44C8-B2F0-F77B557E39BA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAlbUSZ0ACgkQ+ENDeYKZi37xGwCfZuPCWxo1eYK3JZaeLTUen49/
cBgAnjt25stR1QRy52hv3ZCtmMW19xj0
=Q6H7
-----END PGP SIGNATURE-----

--Apple-Mail=_1E00F30E-FC21-44C8-B2F0-F77B557E39BA--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CEC1F737-32E1-478D-A3AB-3473BF14B28F>