From owner-freebsd-net@FreeBSD.ORG Wed Apr 15 14:13:42 2015 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EA03D9D for ; Wed, 15 Apr 2015 14:13:42 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 540EA659 for ; Wed, 15 Apr 2015 14:13:41 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t3FEDc6J029666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 15 Apr 2015 17:13:38 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t3FEDbV8029665; Wed, 15 Apr 2015 17:13:37 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 15 Apr 2015 17:13:37 +0300 From: Gleb Smirnoff To: Luigi Rizzo Cc: "freebsd-net@freebsd.org" Subject: Re: moving ALTQ out of contrib Message-ID: <20150415141337.GE883@glebius.int.ru> References: <20150414135346.GU883@FreeBSD.org> <20150415073823.GA94402@onelab2.iet.unipi.it> <20150415122627.GZ883@glebius.int.ru> <20150415125944.GD883@glebius.int.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 14:13:43 -0000 On Wed, Apr 15, 2015 at 03:02:03PM +0200, Luigi Rizzo wrote: L> > L> Then if you do sys/net/altq/ do you also plan to split the current L> > L> content of sys/net/ into separate subdirectories ? L> > L> L> > L> We currently have quite a few separate things in sys/net/, such as L> > L> - various bpf files L> > L> - generic ifnet support (including raw sockets) L> > L> - various libraries (compression and hash functions) L> > L> - routing code L> > L> - bridging code L> > L> - a ton of special ifnets, (tun, tap, epair, gif, ....) L> > L> - bridging code L> > L> that could benefit from a bit of partitioning L> > L> > I definitely agree that a) special interfaces b) lagg+lacp L> > c) generic libraries should be separated. I don't mind if anyone does L> > this job :) L> > L> > But I personally would prefer is this is done after the lifetime L> > of the projects/ifnet branch, since if stuff is moved while I work L> > on projects/ifnet, my merging will become a nightmare. I already have L> > conflicts quite often. L> > L> L> sure, there is no rush. L> I was just trying to understand why your preference is for sys/net/altq L> instead of sys/netaltq as we have for other components. I think that dropping everything into sys/ is historical. Perfectly, protoctols should live in net/ as well, like net/inet and net/inet6, but of course no one would support that move. The most recent network related subdir in sys/ is netpfil. Frankly speaking I didn't like the name, and that word wasn't my, but Bjoern's. But, if I advocated for net/pfil, then the argument would be that pfil hooks reside in sys/netinet and in sys/netinet6, not in sys/net, thus moving that into net/pfil is wrong. At the time I really wanted to gather or pfil consumers in one place, and move pf out of contrib, so I accepted name suggested by Bjoern without arguing. -- Totus tuus, Glebius.