From owner-freebsd-threads@FreeBSD.ORG  Tue Oct 21 08:13:49 2008
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6C451065679;
	Tue, 21 Oct 2008 08:13:49 +0000 (UTC) (envelope-from nkoch@demig.de)
Received: from www61.your-server.de (www61.your-server.de [213.133.104.61])
	by mx1.freebsd.org (Postfix) with ESMTP id A4B1C8FC08;
	Tue, 21 Oct 2008 08:13:49 +0000 (UTC) (envelope-from nkoch@demig.de)
Received: from [217.7.243.216] (helo=firewall.demig.intra)
	by www61.your-server.de with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.69) (envelope-from <nkoch@demig.de>)
	id 1KsBvE-0001sL-Mo; Tue, 21 Oct 2008 09:44:56 +0200
Received: from [192.168.148.72] (ws-pr-3.demig.intra [192.168.148.72])
	by firewall.demig.intra (8.14.3/8.14.0) with ESMTP id m9L7i6sg042719;
	Tue, 21 Oct 2008 09:44:06 +0200 (CEST) (envelope-from nkoch@demig.de)
Message-ID: <48FD88B1.3050106@demig.de>
Date: Tue, 21 Oct 2008 07:45:53 +0000
From: Norbert Koch <nkoch@demig.de>
Organization: demig Prozessautomatisierung GmbH
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: freebsd-hackers@freebsd.org, freebsd-threads@freebsd.org
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.64 on 192.168.148.235
X-Authenticated-Sender: webmaster@demig.de
X-Virus-Scanned: Clear (ClamAV 0.94/8457/Tue Oct 21 05:05:55 2008)
Cc: 
Subject: 'libc_r: enter/leave_cancellation_point()
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2008 08:13:50 -0000

Hello,

I was just inspecting libc_r for trying to understand
some things and found this:

<-------------------------

--- src/lib/libc_r/uthread/uthread_cond.c	2002/05/24 04:32:28	1.33
+++ src/lib/libc_r/uthread/uthread_cond.c	2002/11/13 18:13:26	1.34

...

  int
-_pthread_cond_signal(pthread_cond_t * cond)
+__pthread_cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex,
+		       const struct timespec *abstime)
+{
+	int ret;
+
+	_thread_enter_cancellation_point();
+	ret = _pthread_cond_timedwait(cond, mutex, abstime);
+	_thread_enter_cancellation_point();
+	return (ret);
+}


---------------------------->

Shouldn't that be _thread_leave_cancellation_point() after
calling _pthread_cond_timedwait() ?
What effect should I see if this is wrong?

Best regards,

Norbert Koch