From owner-cvs-src@FreeBSD.ORG Thu Oct 25 19:10:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2915A16A46C; Thu, 25 Oct 2007 19:10:41 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id BA9E313C4A3; Thu, 25 Oct 2007 19:10:40 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9PJAVO0063379; Thu, 25 Oct 2007 13:10:31 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4720EA15.40002@samsco.org> Date: Thu, 25 Oct 2007 13:10:13 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: d@delphij.net References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720E0AF.1010004@samsco.org> <4720E904.2090704@delphij.net> In-Reply-To: <4720E904.2090704@delphij.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Thu, 25 Oct 2007 13:10:31 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 19:10:41 -0000 LI Xin wrote: > Scott Long wrote: >> Andrey Chernov wrote: >>> On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: >>>> Andrey A. Chernov wrote: >>>>> ache 2007-10-15 09:51:30 UTC >>>>> FreeBSD src repository >>>>> Modified files: >>>>> lib/libc/locale utf8.c Log: >>>>> Add comment explaining __mb_sb_limit trick here. >>>>> Revision Changes Path >>>>> 1.16 +5 -0 src/lib/libc/locale/utf8.c >>>> When is the ABI damage from this going to be fixed? >>> There is no ABI damage in -current. >>> >> Exposing the __mb_sb_limit symbol has instantly created a need >> to have a compat7x package, and is causing many users problems >> during upgrades and normal operations. It may not be a problem >> for you, Andre, but it's a problem for everyone else. Please >> respect this and fix it. > > Well, I think the problem is not exposing a new symbol by itself, but > __mb_sb_limit is being used in _ctype.h, in a form of __inline > functions. Therefore, the change will break new binaries running on > older systems. Personally I think this is acceptable, but maybe we > could have a better way to avoid this, because the binaries are no > longer backward compatible (i.e. you may have trouble running a program > compiled for 6.3-RELEASE on 6.2-RELEASE, if it uses locale bits). If this is true, then it directly violates the API/ABI compatability guidelines that were developed and agreed to by the project in 2005. Scott