Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Jan 2002 18:42:30 +0000
From:      Josef Karthauser <joe@tao.org.uk>
To:        Josef Karthauser <joe@tao.org.uk>, Nate Williams <nate@yogotech.com>, Sheldon Hearn <sheldonh@starjuice.net>, Terry Lambert <tlambert2@mindspring.com>, arch@FreeBSD.ORG
Subject:   Re: Adding support for a global src tree serial number
Message-ID:  <20020131184230.D84715@genius.tao.org.uk>
In-Reply-To: <20020131183321.GA59544@gattaca.yadt.co.uk>; from davidt@yadt.co.uk on Thu, Jan 31, 2002 at 06:33:21PM %2B0000
References:  <3C5944A4.4927F812@mindspring.com> <80628.1012484102@axl.seasidesoftware.co.za> <15449.30438.698921.182380@caddis.yogotech.com> <20020131173702.J77899@genius.tao.org.uk> <20020131183321.GA59544@gattaca.yadt.co.uk>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Thu, Jan 31, 2002 at 06:33:21PM +0000, David Taylor wrote:
> 
> #define SERIALNUM "20020122_1"
> 
> So the file is just #include'd where needed.

The problem is where to put the serial number, and how to distribute it.
It needs to be maintained in a ,v file for cvs to be able to check it
out.  That adds additional complexity.

> I also added the serialnum to the commit mail.
> 
> >     l=`find /usr/src/sys | xargs grep '\$FreeBSD:.*$' | sed \
> > 	's/.*\$FreeBSD://' | awk '{ print $3 "-" $4 }' | sort -n | tail -1`
> 
> That can take ages, and isn't necesarily correct if parts of src/ aren't
> present.  I thought the idea was for a quickly obtainable number that can
> be included with PRs, and stored inside the kernel or whatever.

It's correct enough to give a the "effect latest source" date for
a particular kernel build irrespective of what parts of the tree
are there.  It doesn't matter if alpha/ has been committed to more
recently if that source isn't being used in this kernel.

Also, it doesn't take "ages".  It takes a little while, but not ages.

Joe

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjxZkBUACgkQXVIcjOaxUBaINQCg4FHth7kxM7C+SzYTnnOUSXMa
U70An0zrhVqiSFC9Ol4LVLqVB/3YOSKQ
=jou+
-----END PGP SIGNATURE-----
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020131184230.D84715>