From owner-freebsd-bugs  Thu Jul  5 14:50: 7 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id A62F237B40A
	for <freebsd-bugs@hub.freebsd.org>; Thu,  5 Jul 2001 14:50:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f65Lo1u20230;
	Thu, 5 Jul 2001 14:50:01 -0700 (PDT)
	(envelope-from gnats)
Received: from rodent.utcs.utoronto.ca (rodent.utcs.utoronto.ca [128.100.102.5])
	by hub.freebsd.org (Postfix) with SMTP id F1EED37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  5 Jul 2001 14:48:59 -0700 (PDT)
	(envelope-from pkern@utcs.utoronto.ca)
Received: by rodent.utcs.utoronto.ca id <444525>; Thu, 5 Jul 2001 17:48:56 -0400
Message-Id: <01Jul5.174856edt.444525@rodent.utcs.utoronto.ca>
Date: Thu, 5 Jul 2001 17:48:48 -0400
From: pkern@utcs.utoronto.ca
Reply-To: pkern@utcs.utoronto.ca
To: FreeBSD-gnats-submit@freebsd.org
Cc: pkern@utcs.utoronto.ca
X-Send-Pr-Version: 3.113
Subject: bin/28738: IPFW log messages causes syslogd to fsync.
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         28738
>Category:       bin
>Synopsis:       IPFW log messages causes syslogd to fsync.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 05 14:50:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     pkern
>Release:        FreeBSD 4.3-RELEASE i386
>Organization:
Computing and Network Services, University of Toronto
>Environment:
System: FreeBSD knobs.utcs 4.3-RELEASE FreeBSD 4.3-RELEASE #57: Thu Jul 5 18:49:34 EDT 2001 pkern@knobs.utcs:/usr/src/sys/compile/KWAI i386


>Description:
	
	syslogd is set to fsync after each klog message.
	This results in a lot of disk activity if IPFW is being used
	with verbose logging enabled -- an fsync for each IPFW syslog
	(and there could be more than one IPFW log message per packet).
	But IPFW syslogs use the LOG_SECURITY facility so it's possible
	to exempt those messages from being fsync'ed each time.

>How-To-Repeat:
>Fix:

	--- syslogd.c	2001/06/12 08:25:31	1.1
	+++ syslogd.c	2001/06/12 16:39:49
	@@ -712,6 +712,8 @@
				++p;
			if ((pri & LOG_FACMASK) == LOG_CONSOLE)
				flags |= IGN_CONS;
	+		if ((pri & LOG_FACMASK) == LOG_SECURITY)
	+			flags &= ~SYNC_FILE;
		} else {
			/* kernel printf's come out on console */
			flags |= IGN_CONS;
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message