From owner-freebsd-bugs@FreeBSD.ORG  Wed Apr 27 09:20:15 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7E78516A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 27 Apr 2005 09:20:15 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5AD6843D55
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 27 Apr 2005 09:20:15 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3R9KFXd072404
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 27 Apr 2005 09:20:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3R9KEpZ072403;
	Wed, 27 Apr 2005 09:20:14 GMT
	(envelope-from gnats)
Date: Wed, 27 Apr 2005 09:20:14 GMT
Message-Id: <200504270920.j3R9KEpZ072403@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Ian Dowse <iedowse@maths.tcd.ie>
Subject: Re: kern/80390: fstatfs() returns wrong flags or
	libexec/rtld-elf/rtld.c is broken 
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Ian Dowse <iedowse@maths.tcd.ie>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2005 09:20:15 -0000

The following reply was made to PR kern/80390; it has been noted by GNATS.

From: Ian Dowse <iedowse@maths.tcd.ie>
To: Andre Albsmeier <Andre.Albsmeier@siemens.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: kern/80390: fstatfs() returns wrong flags or libexec/rtld-elf/rtld.c is broken 
Date: Wed, 27 Apr 2005 10:19:50 +0100

 In message <200504270652.j3R6qSxv038497@curry.mchp.siemens.de>, Andre Albsmeier
  writes:
 >On a FreeBSD 5.4-STABLE system fstatfs() used on an NFS mounted
 >volume now returns the NFS mount option flags (as defined in
 >sys/nfsclient/nfsargs.h) instead of the "normal" filesystem
 >flags as defined in sys/sys/mount.h.
 
 I wonder if the following would be more appropriate? This change
 was made in the CSRG sources in March 1995, but the equivalent
 change was not made to FreeBSD when the NFSv3 import happened a few
 months later. Maybe there is something in the kernel that depends
 on getting the NFS flags this way though.
 
 Ian
 
 Index: nfs_vfsops.c
 ===================================================================
 RCS file: /dump/FreeBSD-CVS/src/sys/nfsclient/nfs_vfsops.c,v
 retrieving revision 1.172
 diff -u -r1.172 nfs_vfsops.c
 --- nfs_vfsops.c	24 Mar 2005 07:37:22 -0000	1.172
 +++ nfs_vfsops.c	27 Apr 2005 09:12:56 -0000
 @@ -266,7 +266,6 @@
  		goto nfsmout;
  	}
  	sfp = nfsm_dissect(struct nfs_statfs *, NFSX_STATFS(v3));
 -	sbp->f_flags = nmp->nm_flag;
  	sbp->f_iosize = nfs_iosize(nmp);
  	if (v3) {
  		sbp->f_bsize = NFS_FABLKSIZE;