Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 07 Sep 2023 07:12:11 +0000
From:      bugzilla-noreply@freebsd.org
To:        net@FreeBSD.org
Subject:   [Bug 273559] [iflib] numa allocation
Message-ID:  <bug-273559-7501-zxmgsg9B3K@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-273559-7501@https.bugs.freebsd.org/bugzilla/>
References:  <bug-273559-7501@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273559

Zhenlei Huang <zlei@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zlei@FreeBSD.org

--- Comment #1 from Zhenlei Huang <zlei@FreeBSD.org> ---
(In reply to Konrad from comment #0)

The lagg(4) has no changes related to NUMA since Nov 19 2021.

>From the logic in `sys/net/if_lagg.c`:=20
```
struct lagg_port *
lacp_select_tx_port(struct lagg_softc *sc, struct mbuf *m, int *err)
{
        struct lacp_softc *lsc =3D LACP_SOFTC(sc);
        uint32_t hash;
        uint8_t numa_domain;

        if ((sc->sc_opts & LAGG_OPT_USE_FLOWID) &&
            M_HASHTYPE_GET(m) !=3D M_HASHTYPE_NONE)
                hash =3D m->m_pkthdr.flowid >> sc->flowid_shift;
        else
                hash =3D m_ether_tcpip_hash(sc->sc_flags, m, lsc->lsc_hashk=
ey);

        numa_domain =3D m->m_pkthdr.numa_domain;
        return (lacp_select_tx_port_by_hash(sc, hash, numa_domain, err));
}
```

I guess `numa_domain` in mbuf packet header is not set correctly. That shou=
ld
be done in driver IIUC.

I do not have NUMA devices, can you please share the debug info for
`m->m_pkthdr.numa_domain` ?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273559-7501-zxmgsg9B3K>