Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Feb 2019 04:47:59 -0800 (PST)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Mateusz Piotrowski <0mp@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r344570 - head/usr.sbin/sysrc
Message-ID:  <201902261247.x1QClxsH044906@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201902260928.x1Q9SBp7098439@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> Author: 0mp (ports committer)
> Date: Tue Feb 26 09:28:10 2019
> New Revision: 344570
> URL: https://svnweb.freebsd.org/changeset/base/344570
> 
> Log:
>   sysrc.8: Pet igor and mandoc

This only tells the source of why you changed some,
a good commit log entry tells me that, and what it
is that you changed.  You normally do not need to
name the file your changed in a commit log as the
log is attached to the file, sometimes it does make
since to mention a file name in a log entry when you
are describing the changes to just that file in a
commit that includes many files.

A better log might of been:
  Pet igor and mandoc.  Remove unneeded .Li, use .Fx as needed,
  escape hard stop, and sort cross references.

I thank you for the cleanup.

>   Reviewed by:	bcr
>   Approved by:	bcr (doc)
>   Approved by:	krion (mentor, implicit), mat (mentor, implicit)
>   Differential Revision:	https://reviews.freebsd.org/D19348
> 
> Modified:
>   head/usr.sbin/sysrc/sysrc.8
> 
> Modified: head/usr.sbin/sysrc/sysrc.8
> ==============================================================================
> --- head/usr.sbin/sysrc/sysrc.8	Tue Feb 26 08:18:34 2019	(r344569)
> +++ head/usr.sbin/sysrc/sysrc.8	Tue Feb 26 09:28:10 2019	(r344570)
> @@ -24,7 +24,7 @@
>  .\"
>  .\" $FreeBSD$
>  .\"
> -.Dd February 2, 2016
> +.Dd February 26, 2019
>  .Dt SYSRC 8
>  .Os
>  .Sh NAME
> @@ -144,7 +144,7 @@ Disable verbose and hide certain errors.
>  When combined with
>  .Sq Fl L
>  and one or more
> -.Li Ar name
> +.Ar name
>  arguments, provide only exit status and no output.
>  .It Fl R Ar dir
>  Operate within the root directory
> @@ -216,7 +216,8 @@ The list of system configuration files is configured i
>  within the variable
>  .Ql rc_conf_files ,
>  which by-default contains a space-separated list of pathnames.
> -On all FreeBSD
> +On all
> +.Fx
>  systems, this defaults to the value "/etc/rc.conf /etc/rc.conf.local".
>  Each
>  pathname is sourced in-order upon startup.
> @@ -276,7 +277,7 @@ it is added
>  For convenience, if the first character is alpha-numeric
>  .Pq letters A-Z, a-z, or numbers 0-9 ,
>  dot
> -.Pq Li . ,
> +.Pq Li \&. ,
>  or slash
>  .Pq Li / ,
>  .Nm
> @@ -334,7 +335,7 @@ it is removed
>  For convenience, if the first character is alpha-numeric
>  .Pq letters A-Z, a-z, or numbers 0-9 ,
>  dot
> -.Pq Li . ,
> +.Pq Li \&. ,
>  or slash
>  .Pq Li / ,
>  .Nm
> @@ -466,11 +467,11 @@ cloned_interfaces+"alternate"
>  .Dl returns "alternate" if $cloned_interfaces is set .
>  .Sh SEE ALSO
>  .Xr rc.conf 5 ,
> -.Xr rc.subr 8 ,
>  .Xr jail 8 ,
>  .Xr jexec 8 ,
>  .Xr jls 8 ,
>  .Xr rc 8 ,
> +.Xr rc.subr 8 ,
>  .Xr sysctl 8
>  .Sh HISTORY
>  A
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902261247.x1QClxsH044906>