From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jun 13 09:30:32 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D7B716A4D0; Sun, 13 Jun 2004 09:30:32 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 114F143D58; Sun, 13 Jun 2004 09:30:32 +0000 (GMT) (envelope-from thierry@FreeBSD.org) Received: from freefall.freebsd.org (thierry@localhost [127.0.0.1]) i5D8elYH035187; Sun, 13 Jun 2004 08:40:47 GMT (envelope-from thierry@freefall.freebsd.org) Received: (from thierry@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5D8elu5035173; Sun, 13 Jun 2004 08:40:47 GMT (envelope-from thierry) Date: Sun, 13 Jun 2004 08:40:47 GMT From: Thierry Thomas Message-Id: <200406130840.i5D8elu5035173@freefall.freebsd.org> To: jacke@bofh.pl, thierry@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/61383: New port: net/t38modem, H.323 compliant fax machine. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2004 09:30:32 -0000 Synopsis: New port: net/t38modem, H.323 compliant fax machine. State-Changed-From-To: open->feedback State-Changed-By: thierry State-Changed-When: Sun Jun 13 08:34:11 GMT 2004 State-Changed-Why: Since OpenH323 is no more forbidden, I have checked this port. 1) The Makefile headers are missing, and comms seems a better category. I propose the following patch: --- t38modem.diff begins here --- diff -urN net/t38modem.orig/Makefile comms/t38modem/Makefile --- net/t38modem.orig/Makefile Sat Jun 12 21:36:24 2004 +++ comms/t38modem/Makefile Sun Jun 13 10:29:29 2004 @@ -1,23 +1,31 @@ -PORTNAME= t38modem -PORTVERSION= 0.6.2 -PORTREVISION= 1 -CATEGORIES= net +# ports collection makefile for: t38modem +# Date created: Thu Jan 15 2004 +# Whom: Jakub Klausa +# +# $FreeBSD$ +# + +PORTNAME= t38modem +PORTVERSION= 0.6.2 +CATEGORIES= comms net MASTER_SITES= http://www.openh323.org/bin/ DISTNAME= t38modem_${PORTVERSION} MAINTAINER= jacke@bofh.pl -COMMENT= T.38 Fax/Modem machine (from OpenH323). +COMMENT= T.38 Fax/Modem machine (from OpenH323) BUILD_DEPENDS= ${NONEXISTENT}:${PORTSDIR}/net/openh323:build +PLIST_FILES= bin/t38modem + WRKSRC= ${WRKDIR}/t38modem NOCLEANDEPENDS= yes USE_GMAKE= yes -ALL_TARGET= all +ALL_TARGET= all MAKE_ENV= PWLIBDIR=${WRKDIRPREFIX}${.CURDIR}/../../devel/pwlib/work/pwlib \ - OPENH323DIR=${WRKDIRPREFIX}${.CURDIR}/../openh323/work/openh323 + OPENH323DIR=${WRKDIRPREFIX}${.CURDIR}/../../net/openh323/work/openh323 THE_MACHTYPE= ${ARCH:S/i386/x86/} do-install: diff -urN net/t38modem.orig/pkg-plist comms/t38modem/pkg-plist --- net/t38modem.orig/pkg-plist Sat Jun 12 21:36:24 2004 +++ comms/t38modem/pkg-plist Thu Jan 1 01:00:00 1970 @@ -1,2 +0,0 @@ -bin/t38modem - --- t38modem.diff ends here --- 2) It does not respect PTHREAD_LIBS, and always uses -pthread. Then compilation aborts: cd /usr/ports/comms/t38modem/../../net/openh323/work/openh323/lib ; rm -f libh323_FreeBSD_x86_r.so ; ln -sf libh323_FreeBSD_x86_r.so.1.12.0 libh323_FreeBSD_x86_r.so cd /usr/ports/comms/t38modem/../../net/openh323/work/openh323/lib ; rm -f libh323_FreeBSD_x86_r.so.1 ; ln -sf libh323_FreeBSD_x86_r.so.1.12.0 libh323_FreeBSD_x86_r.so.1 cd /usr/ports/comms/t38modem/../../net/openh323/work/openh323/lib ; rm -f libh323_FreeBSD_x86_r.so.1.12 ; ln -sf libh323_FreeBSD_x86_r.so.1.12.0 libh323_FreeBSD_x86_r.so.1.12 gmake[2]: Leaving directory `/usr/ports/net/openh323/work/openh323/src' gmake[2]: Entering directory `/usr/ports/net/openh323/work/openh323/samples/simple' g++ -o obj_FreeBSD_x86_r/simph323 -O -pipe -march=pentium4 -L/usr/local/lib -L/usr/local/lib -L/usr/local/lib -s -L/usr/ports/devel/pwlib/work/pwlib/lib -L/usr/ports/comms/t38modem/../../net/openh323/work/openh323/lib ./obj_FreeBSD_x86_r/main.o -lh323_FreeBSD_x86_r -lpt_FreeBSD_x86_r -lavcodec -lssl -lcrypto -llber -lldap -lldap_r -lexpat -pthread /usr/ports/comms/t38modem/../../net/openh323/work/openh323/lib/libh323_FreeBSD_x86_r.so: undefined reference to `avcodec_fprintf_fn' gmake[2]: *** [obj_FreeBSD_x86_r/simph323] Erreur 1 gmake[2]: Leaving directory `/usr/ports/net/openh323/work/openh323/samples/simple' gmake[1]: *** [opt] Erreur 2 gmake[1]: Leaving directory `/usr/ports/net/openh323/work/openh323' gmake: *** [libs] Erreur 2 *** Error code 2 Stop in /usr/ports/comms/t38modem. http://www.freebsd.org/cgi/query-pr.cgi?pr=61383