From owner-cvs-src@FreeBSD.ORG Wed Nov 30 13:20:35 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7580716A41F; Wed, 30 Nov 2005 13:20:35 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id E13D943D7C; Wed, 30 Nov 2005 13:20:23 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 2869515 for multiple; Wed, 30 Nov 2005 08:18:20 -0500 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jAUDKHAC080362; Wed, 30 Nov 2005 08:20:19 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Robert Watson Date: Wed, 30 Nov 2005 08:20:13 -0500 User-Agent: KMail/1.8.3 References: <200511292307.jATN7EJH055853@repoman.freebsd.org> <20051130091930.K95395@fledge.watson.org> In-Reply-To: <20051130091930.K95395@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200511300820.15431.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2005 13:20:35 -0000 On Wednesday 30 November 2005 04:20 am, Robert Watson wrote: > On Tue, 29 Nov 2005, John Baldwin wrote: > > Fix snderr() to not leak the socket buffer lock if an error occurs in > > sosend(). Robert accidentally changed the snderr() macro to jump to t= he > > out label which assumes the lock is already released rather than the > > release label which drops the lock in his previous change to sosend(). > > This should fix the recent panics about returning from write(2) with t= he > > socket lock held and the most recent LOR on current@. > > Thanks for fixing this -- I ran this patch in testing for ages, but must > have done some "clean up" or other such 99.85% harmless activity :-(. No problem. At least you didn't commit it and then immediately leave for a= =20 small island in the Carribbean without any inet access for a week. :) =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org