From owner-freebsd-stable@FreeBSD.ORG Mon Apr 4 06:20:13 2011 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA6F5106564A; Mon, 4 Apr 2011 06:20:13 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id EE6048FC08; Mon, 4 Apr 2011 06:20:12 +0000 (UTC) Received: by wwc33 with SMTP id 33so5831312wwc.31 for ; Sun, 03 Apr 2011 23:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:organization:references :sender:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=13htVigszmlm9jdpNu+vTh4GZTdPVwJlMEzHKxfSnKs=; b=TdmbtRIUTM6AFL+PvueBOv8W5xpXnCT8ap3s7HYUpRF/fMnM8CSbMeZiO8Opsd2m/a J0aCISvOtLrt9/nnjQ9pBTmeacYv1dan0ULu3TK+ksoniRgDpjmo8xJgj/a+/PWa/5tV LBnUpmcTF9kIcq6pSys9hCpItdQvynj5AW4aM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=pXUX0WW9oURDbpc/3fz6j5sctYCjyjmiAx8TqBwXzQ8yByaxon5988q+JUgbJl14qL ioquQ+WPMeqruSom4+pxwLJssiklm6YhkLdPA9VgLQPp00iUSQDmp7mcA5K+XPXnHueV dXz/dLbdbplRrhXFx8wP5j06AFyKairUK6aMA= Received: by 10.216.121.208 with SMTP id r58mr3389718weh.61.1301898012007; Sun, 03 Apr 2011 23:20:12 -0700 (PDT) Received: from localhost ([94.27.39.186]) by mx.google.com with ESMTPS id x1sm2715815wbh.19.2011.04.03.23.20.10 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 03 Apr 2011 23:20:10 -0700 (PDT) From: Mikolaj Golub To: Victor Balada Diaz Organization: TOA Ukraine References: <20110326003348.GQ36706@equilibrium.bsdes.net> <20110401174354.GE1289@equilibrium.bsdes.net> <86pqp53cqe.fsf@kopusha.home.net> <20110402101750.GD1849@garage.freebsd.pl> <86zko7nsby.fsf@kopusha.home.net> <20110403235124.GF1289@equilibrium.bsdes.net> Sender: Mikolaj Golub Date: Mon, 04 Apr 2011 09:20:08 +0300 In-Reply-To: <20110403235124.GF1289@equilibrium.bsdes.net> (Victor Balada Diaz's message of "Mon, 4 Apr 2011 01:51:24 +0200") Message-ID: <864o6ek06f.fsf@in138.ua3> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kostik Belousov , stable@freebsd.org, Pawel Jakub Dawidek Subject: Re: geli(4) memory leak X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2011 06:20:14 -0000 On Mon, 4 Apr 2011 01:51:24 +0200 Victor Balada Diaz wrote: VBD> On Sun, Apr 03, 2011 at 08:43:45PM +0300, Mikolaj Golub wrote: >> >> On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote: >> >> PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote: >> >> For me your patch look correct. But the same issue is for read :-). Also, to >> >> avoid the leak I think we can just do g_destroy_bio() before "all sectors" >> >> check. See the attached patch (had some testing). >> >> PJD> The patch looks good. Please commit. >> >> Commited, thanks. VBD> I've been out all the weekend, so i've been unable to answer before. I'm glad VBD> it got commited and it's great you discovered and fixed the same problem on the VBD> read path. VBD> Are there any plans to MFC this? Approximately after one week. -- Mikolaj Golub