From nobody Mon Feb 6 10:34:33 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P9N1C75Qnz3npqh; Mon, 6 Feb 2023 10:34:39 +0000 (UTC) (envelope-from idefix@fechner.net) Received: from anny.lostinspace.de (anny.lostinspace.de [IPv6:2001:608:a02::33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4P9N1C1Vdyz3lHy; Mon, 6 Feb 2023 10:34:39 +0000 (UTC) (envelope-from idefix@fechner.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=fechner.net header.s=default header.b="kW5KE/D3"; spf=pass (mx1.freebsd.org: domain of idefix@fechner.net designates 2001:608:a02::33 as permitted sender) smtp.mailfrom=idefix@fechner.net; dmarc=pass (policy=none) header.from=fechner.net Received: from server2.idefix.lan (beta.fechner.net [89.58.45.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 0686B8D44F; Mon, 6 Feb 2023 11:34:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fechner.net; s=default; t=1675679676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0MsQOKgwtDbkD4NjlNI9jX1Rx3CM+i7GHSYR4B0nWI=; b=kW5KE/D33rJ1UI4B7ew6Xra9gJE4TGQpp1XnNdC5cxlHjLjFr9QqcIOTAMdWHCCXUhm6WI 4wMwrrKQ+3qSDlbWTJc6r1i+tEA5C9PGK8ShxOXADGqInvx11pcJoijkx+/PBlkumUlwoN NeP2Djxxw7GGcX0umwc+/sj3KuKbiUk= Received: from [192.168.0.151] (unknown [93.182.104.249]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by server2.idefix.lan (Postfix) with ESMTPSA id 0E113E17B6; Mon, 6 Feb 2023 11:34:34 +0100 (CET) Message-ID: Date: Mon, 6 Feb 2023 12:34:33 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: git: 0983bbffe275 - main - devel/rubygem-oj: Fix build Content-Language: en-US To: Yasuhiro Kimura , bofh@FreeBSD.org Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202301181534.30IFYYOw066510@gitrepo.freebsd.org> <20230127.191713.2183382863074960001.yasu@FreeBSD.org> From: Matthias Fechner In-Reply-To: <20230127.191713.2183382863074960001.yasu@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: anny.lostinspace.de X-Spamd-Result: default: False [-6.70 / 15.00]; DWL_DNSWL_MED(-2.00)[fechner.net:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; DMARC_POLICY_ALLOW(-0.50)[fechner.net,none]; R_DKIM_ALLOW(-0.20)[fechner.net:s=default]; RCVD_IN_DNSWL_MED(-0.20)[2001:608:a02::33:from]; R_SPF_ALLOW(-0.20)[+a]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@FreeBSD.org,dev-commits-ports-main@FreeBSD.org]; ASN(0.00)[asn:5539, ipnet:2001:608::/32, country:DE]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[fechner.net:+]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4P9N1C1Vdyz3lHy X-Spamd-Bar: ------ X-ThisMailContainsUnwantedMimeParts: N Am 27.01.2023 um 12:17 schrieb Yasuhiro Kimura: > Unfortunately build still fails after this commit. > "${INSTALL_DATA} -d" creates directory with 0644 and it result in > failing to copy header files with 'permission denied'. Attached patch > fixes it. It uses "${INSTALL} -d" instead. So directory is created > with 0755 and now header files are copied successfully. > > From 3a01bac7a4793cc191bc605fbb81b0380ab26959 Mon Sep 17 00:00:00 2001 > From: Yasuhiro Kimura > Date: Fri, 27 Jan 2023 18:41:22 +0900 > Subject: [PATCH] devel/rubygem-oj: Create directoy with proper mode > > "${INSTALL_DATA} -d" creates directory with 0644 and it result in > failing to copy header files with 'permission denied'. So use > "${INSTALL} -d" instead.It creates directory with 0755 and header > files are copied successfully. > > Fixes: 0983bbffe275 > --- > devel/rubygem-oj/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/devel/rubygem-oj/Makefile b/devel/rubygem-oj/Makefile > index 374e6a43edc7..367164535c29 100644 > --- a/devel/rubygem-oj/Makefile > +++ b/devel/rubygem-oj/Makefile > @@ -1,6 +1,6 @@ > PORTNAME= oj > PORTVERSION= 3.13.23 > -PORTREVISION= 2 > +PORTREVISION= 3 > CATEGORIES= devel rubygems > MASTER_SITES= RG > > @@ -16,7 +16,7 @@ USES= gem > # TODO: find a better way to do this > # Copy all header file, as it is required by rubygem-oj-introspect > post-install: > - ${INSTALL_DATA} -d ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj > + ${INSTALL} -d ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj > cd ${WRKSRC}/ext/oj && ${FIND} * -name "*.h" -type f -exec ${INSTALL_DATA} {} "${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj/{}" \; > > .include thanks for your patch. I committed it, so it should now also be fixed for NONE-ROOT builds. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook