From owner-cvs-src-old@FreeBSD.ORG Sun Feb 28 16:26:11 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 540BC1065780 for ; Sun, 28 Feb 2010 16:26:11 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4369F8FC1E for ; Sun, 28 Feb 2010 16:26:11 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o1SGQB5t067128 for ; Sun, 28 Feb 2010 16:26:11 GMT (envelope-from kib@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o1SGQBeS067127 for cvs-src-old@freebsd.org; Sun, 28 Feb 2010 16:26:11 GMT (envelope-from kib@repoman.freebsd.org) Message-Id: <201002281626.o1SGQBeS067127@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to kib@repoman.freebsd.org using -f From: Konstantin Belousov Date: Sun, 28 Feb 2010 16:25:49 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_tap.c if_tun.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2010 16:26:11 -0000 kib 2010-02-28 16:25:49 UTC FreeBSD src repository Modified files: sys/net if_tap.c if_tun.c Log: SVN rev 204464 on 2010-02-28 16:25:49Z by kib In both if_tun and if_tap: Do not do additional dev_ref() on the newly created interface in the if_clone create method [1]. This reference is not needed and never removed, causing struct cdevpriv leakage. Remove the setting of SI_CHEAPCLONE flag as well, since it is unused. For dev_clone handlers, create cdevs with the call make_dev_credf(MAKEDEV_REF) instead of calling make_dev() and then dev_ref(), to avoid a race. Call drain_dev_clone_events() at the module unload time after dev_clone handler is deinstalled. Submitted by: Mikolaj Golub [1] MFC after: 1 week Revision Changes Path 1.82 +3 -10 src/sys/net/if_tap.c 1.185 +2 -9 src/sys/net/if_tun.c