From owner-cvs-all Tue Dec 29 15:13:11 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA26085 for cvs-all-outgoing; Tue, 29 Dec 1998 15:13:11 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from peedub.muc.de (newpc.muc.ditec.de [194.120.126.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA26052; Tue, 29 Dec 1998 15:12:55 -0800 (PST) (envelope-from garyj@peedub.muc.de) Received: from peedub.muc.de (localhost [127.0.0.1]) by peedub.muc.de (8.9.1/8.6.9) with ESMTP id XAA70186; Tue, 29 Dec 1998 23:48:24 +0100 (CET) Message-Id: <199812292248.XAA70186@peedub.muc.de> X-Mailer: exmh version 2.0.2 2/24/98 To: Poul-Henning Kamp cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin Makefile src/sys/net if_sppp.h if_spppsubr.c src/usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c Reply-To: Gary Jennejohn In-reply-to: Your message of "Sun, 27 Dec 1998 13:30:50 PST." <199812272130.NAA21915@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 29 Dec 1998 23:48:24 +0100 From: Gary Jennejohn Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Poul-Henning Kamp writes: >phk 1998/12/27 13:30:50 PST > > Modified files: > usr.sbin Makefile > sys/net if_sppp.h if_spppsubr.c > Added files: > usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c > Log: > Update sppp support to i4b level. This includes the new spppcontrol > program to set PPP options like authentication with. > what about this code from sppp_ipcp_RCR() in the i4b source ? This actually _uses_ gotmyaddr which appears in a few places in the committted code. I added this because some ISPs actually send the user's IP address a little early. Note that there are some other changes required to set the IPCP_MYADDR_DYN flag. Jo"rg left this code fragment out because he didn't understand what it was doing and I had a short e-mail discussion about it with him but he never committed it. if (!(sp->ipcp.flags & IPCP_MYADDR_SEEN) && (sp->ipcp.flags & IPCP_MYADDR_DYN)) { /* * hopefully this is our address !! */ if (debug) addlog("[wantmyaddr %s] ", sppp_dotted_quad(desiredaddr)); /* * When doing dynamic address assignment, * we accept his offer. Otherwise, we * ignore it and thus continue to negotiate * our already existing value. */ sppp_set_ip_addr(sp, desiredaddr); if (debug) addlog("[agree] "); sp->ipcp.flags |= IPCP_MYADDR_SEEN; gotmyaddr++; continue; } else { I can commit this if there are no disagreements. --- Gary Jennejohn Home - garyj@muc.de Work - garyj@fkr.dec.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message